Giter VIP home page Giter VIP logo

Comments (3)

sindresorhus avatar sindresorhus commented on August 15, 2024 1

I wanted the main method to be simple, because from extensive use, I almost never needed the old value. However, I do agree we should support providing the old value somehow. Maybe a updatesWithPrevious() method or something. It would return a tuple of old/new values though. I considered overloading .updates(), but it may create some ambiguities. I will need to think about it.


For now, you could use these utilities:

extension AsyncStream {
	func withPrevious() -> AsyncStream<(previous: Element?, current: Element)> {
		.init { continuation in
			Task {
				var previous: Element?
				for await element in self {
					continuation.yield((previous, element))
					previous = element
				}

				continuation.finish()
			}
		}
	}

	func withPrevious(initialPreviousValue: Element) -> AsyncStream<(previous: Element, current: Element)> {
		.init { continuation in
			Task {
				var previous = initialPreviousValue
				for await element in self {
					continuation.yield((previous, element))
					previous = element
				}

				continuation.finish()
			}
		}
	}
}

The obvious benefit of having support built-in is that the previous value would be non-optional.

from defaults.

Maschina avatar Maschina commented on August 15, 2024

Since I see the point to get rid of dead wood and streamline the API, I see a strong benefit of using .observe() and that is the KeyChange object, which comprises KeyChange.oldValue. AsyncStream would loose this functionality.

from defaults.

Maschina avatar Maschina commented on August 15, 2024

Would it make sense to extend the AsyncStream implementation with a KeyChange next to Value?

from defaults.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.