Broken with Jasmine 2.5.0? about gulp-jasmine HOT 9 CLOSED

+1
Our builds all starting failing today when our gulp build started silently stopping during our gulp-jasmine tasks... npm-shrinkwrapping to jasmine 2.4.1 fixed the issue

from gulp-jasmine.

Thanks for reporting this. I'll try to have a look tomorrow morning.

from gulp-jasmine.

We are facing the same problem. It looks like the problem is related to https://github.com/jasmine/jasmine-npm/blob/master/lib/jasmine.js#L163, which passes by default and exits the whole nodejs process. Probably gulp-jasmine needs to configure it's own onComplete method to not get into this if-condition?

Unfortunately I'm not familiar enough with the exact internals and how it worked before, so I don't feel confident to work towards a pull request myself.

from gulp-jasmine.

If that's the case, #83 should fix this issue. It's merged, but wasn't released yet. If anyone could test that it fixes the problem, that would be a huge help.

Thanks.

from gulp-jasmine.

I've copied your changes into my local package, and it fixes the problem that the nodejs process gets exited. From that perspective, it should be good.

However, I have a follow up error of the jasmineDone reporter called too often, which results in an Error: task completion callback called too many times error.

from gulp-jasmine.

I can confirm that #83 fixed this issue (that's pretty lucky, right?). I'll prepare a release.

@thoean I didn't have that issue with my very simple expect(1).toBe(1), so it might be a different issue. If you're still seeing the problem after the release, I suggest opening another issue so we can look at it.

from gulp-jasmine.

Fixed in 2.4.1.

from gulp-jasmine.

2.4.1 fixed the issue originally mentioned. So I believe this issue can be closed. Thanks a lot for the quick turn around.

I continue seeing the other problem. I see that a bit later after my next gulp-task starts. I use run-sequence to run multiple tasks, and after a few milliseconds after the next task starts, I get that error. Seems like the next task is already started before gulp-jasmine fully completed (or potentially before jasmine itself fully completed).

I will debug this at some point later and file a new ticket, potentially even towards another library.

from gulp-jasmine.

Update from my side: That was just a silly follow up error of trying to debug things. In addition to returning the "gulp jasmine pipe" I was also calling the callback of the gulp task in the jamineDone event.

Overall, thanks again for your quick turnaround on the main issue. That was really helpful.

from gulp-jasmine.