gulp-mocha dies silently when running too many test files about gulp-mocha HOT 10 CLOSED

I've seen this problem on multiple gulp plugins. I'm not interested in adding an option as it should rather be fixed. Can you open a ticket on gulp?

from gulp-mocha.

These streams should be consumed by stream-consume in orchestrator. Sounds like you need to update.

from gulp-mocha.

Can anybody recommend a workaround? Otherwise I'm going to have to revert to an older version - don't have time to help fix this atm.

from gulp-mocha.

This is caused by this line - https://github.com/sindresorhus/gulp-mocha/blob/master/index.js#L25

@pschuegr you can attach .on('data', function () {}) after .pipe(mocha()) - it will force stream to switch in stream1 mode - which will flush buffers and highWaterMark will be not a problem.

from gulp-mocha.

@pschuegr This is fixed in 1.1.0.

from gulp-mocha.

Perfect! thanks a bunch!

from gulp-mocha.

I'm seeing this issue with the latest [email protected]. However, it silently fails (never runs any of the tests and just completes) when there are 80 or more test files it's trying to deal with. It has something to do with through and adding the files to the queue – this.queue(file). I've added a counter in gulp-mocha/index.js to see if I can get tests to run by limiting the amount of test files to add. See below:

This will pass because I limit it to 79 total tests:

var counter = 0;
return through(function(file) {
	mocha.addFile(file.path);
	// this.queue(file);
	counter++;
	if (counter < 80) {
		console.log('File:', counter, file.path);
		this.queue(file);
	}
}, function() {
	var self = this;
	var d = domain.create();
	var runner;
...

This will silently fail because it uses 80 tests:

var counter = 0;
return through(function(file) {
	mocha.addFile(file.path);
	// this.queue(file);
	counter++;
	if (counter <= 80) {
		console.log('File:', counter, file.path);
		this.queue(file);
	}
}, function() {
	var self = this;
	var d = domain.create();
	var runner;
...

from gulp-mocha.

@hershmire I'd encourage you to mention that issue with the through project if that's truly the culprit (or to triage whether it is).

from gulp-mocha.

I looked into this further. What's the reason for this.queue(file)? I removed it completely and all tests ran.

from gulp-mocha.

https://github.com/dominictarr/through/blob/master/index.js#L40 is the source for that method. I'm not familiar with the through module, though. this will be moot as #151 uses through2

from gulp-mocha.