Giter VIP home page Giter VIP logo

Comments (2)

sindresorhus avatar sindresorhus commented on June 3, 2024

We have a test that shows it should be working, but I'm happy to look further into it if you submit a failing test.

ky/test/main.ts

Lines 407 to 416 in ec6733c

test('throwHttpErrors option', async t => {
const server = await createHttpTestServer();
server.get('/', (_request, response) => {
response.sendStatus(500);
});
await t.notThrowsAsync(ky.get(server.url, {throwHttpErrors: false}).text());
await server.close();
});

from ky.

nekochan0122 avatar nekochan0122 commented on June 3, 2024

We have a test that shows it should be working, but I'm happy to look further into it if you submit a failing test.

ky/test/main.ts

Lines 407 to 416 in ec6733c

test('throwHttpErrors option', async t => {
const server = await createHttpTestServer();
server.get('/', (_request, response) => {
response.sendStatus(500);
});
await t.notThrowsAsync(ky.get(server.url, {throwHttpErrors: false}).text());
await server.close();
});

Sorry, the throwHttpErrors option is working, the Error was throw by other request.

from ky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.