Giter VIP home page Giter VIP logo

Comments (3)

buddyackerman avatar buddyackerman commented on May 20, 2024 2

I'll disagree with your disagreement. That no other implementations don't do it is a poor argument. This could be made part of the options object passed to the parse function. If you don't want it to be the default, fine but it should be an options. It's obvious that querystring parameters are not case sensitive and any querystring parser should handle them as such.

Anyway, I've change my local version to this

return Object.keys(ret).sort().reduce(function (result, key) {
    var val = ret[key];

    //Lowercase the key
    key = key.toLowerCase();

    if (Boolean(val) && typeof val === 'object' && !Array.isArray(val)) {
        // Sort object keys, not values
        result[key] = keysSorter(val);
    } else {
        result[key] = val;
    }

    return result;
}, Object.create(null));

from query-string.

sindresorhus avatar sindresorhus commented on May 20, 2024

I disagree and none of the other querystring implementations do this either.

I want to follow URLSearchParams as much as possible:

x = new URLSearchParams('FOO=1&foo=2');
console.log(Array.from(x.keys()));
//=> ["FOO", "foo"]

from query-string.

sindresorhus avatar sindresorhus commented on May 20, 2024

You never know if a user or some other system is going to provide a querystring parameter in the same case that you expect.

https://github.com/sindresorhus/lowercase-keys

from query-string.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.