Error: spawn E2BIG about trash-cli HOT 7 CLOSED

@BenGitsCode Yeah. I usually use del-cli for deleting node_modules as it's not something I would ever care about recovering.

from trash-cli.

@dawsonbotsford No, that's not what I'm saying. That would be very surprising behavior. I just use del-cli instead of trash when deleting node_modules.

from trash-cli.

You can see here that you are actually talking about a bug in globby. You should report this issue there and close it here as it's not a bug in trash-cli. This is wrong, apologies.

from trash-cli.

@dawsonbotsford No. The issue is that we send too many arguments (files) to the native trash binary.

from trash-cli.

I think @sindresorhus is correct here. Why not just use rm -rf '**/node_modules' for that use instance? I mostly use this module for anytime I'm about to use rm -rf but I hang on the thought "will I ever need this again" and use trash just to be safe—in case I need to recover it later.

from trash-cli.

It seems like directly calling a permanent delete function for path's which contain node_modules is reasonable. Then you would manually remove those paths from the list given to the native trash binary?

If this sounds right, I'd be happy to PR that functionality.

from trash-cli.

Pull request welcome :)

from trash-cli.