FakeXMLHttpRequest falsly sets responseXML about nise HOT 5 CLOSED

When running tests in node using JSDom then I believe this is a deficiency in https://github.com/jindw/xmldom which appears to be a dead project.

However, nise does not seem to check for parsererror tags, which would normally be returned in an error document by a browser (ref: https://developer.mozilla.org/en-US/docs/Web/API/DOMParser) - rather than an exception being thrown as nise seems to expect.

It would seem sensible for nise to check for parsererror and return null if found here https://github.com/sinonjs/nise/blob/master/lib/fake-xhr/index.js#L319-L322 - which I believe would solve this issue when run in a browser.

Eg:

(new DOMParser()).parseFromString('!!!<xml></xml>', 'text/xml').getElementsByTagName('parsererror').length;
1

See also https://stackoverflow.com/questions/11563554/how-do-i-detect-xml-parsing-errors-when-using-javascripts-domparser-in-a-cross

from nise.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from nise.

Should have been fixed by #50.

from nise.

@mnahkies Want to check that this works as you think before we cut a new release?

Clone, npm link in the nise repo, and do npm link nise in your project repo

from nise.

@fatso83 sorry I'm travelling for the next month or so with limited computer access. I had a glance over the pull request and it looked fine to me

from nise.