Regression when $.ajax() XHR includes headers about nise HOT 7 CLOSED

Great find! Sometimes PRs slip throug the cracks :-) Thank you!

from nise.

Probably happened in 082f8e8ab3f8b5d6332550dd05c5b3c6fed82d91, going from [email protected] to [email protected]. Moving this issue over to the nise subproject.

from nise.

@scottohara, if you get a chance to do a git bisect to track down which commit introduced this in nise it would be very helpful.

from nise.

Thanks @fatso83.

git bisect shows the error is in commit d0032f7

This is the only change between v1.3.2 and v1.3.3.

Further analysis shows that the error only occurs if the value of the header being set is numeric

It looks like there's already a PR with a fix for this very issue (#48); so presumably all that needs to happen is to merge that PR and cut a new v1.3.4 release?

from nise.

I closed #48 because it's incorrect to supply a non-string value when setting a header value. That means supplying headers: {"X-FOO": 1} is invalid and should (?) throw an error. The alternative would be to either ignore the error and set the value to "" (empty string) or stringify the value. The latter can give unexpected results, so I'd rather be strict about this. I am thinking we should "fix" this by just giving a better error message. Test libs shouldn't be slack.

from nise.

So, it's not the case that supplying headers is wrong, it's supplying invalid values that fails. In that respect, this isn't a bug, but we should aim to improve the feedback.

from nise.

See PR #53

from nise.