Giter VIP home page Giter VIP logo

Comments (4)

weshouman avatar weshouman commented on August 24, 2024

The default constructor would create a stub that overwrites the original object unknowing about how to restore it.
The stub would work, but a function like restore requires pre-knowledge of the original function behaviour, thus it won't be available.
The current implementation does not provide a restore function for the stubs created by the default constructor, thus the undefined value.

from sinon.

fatso83 avatar fatso83 commented on August 24, 2024

This was closed, but it looks like you wanted a new feature? Not a bug, but missing functionality? Could you describe how you wanted it to look?

from sinon.

weshouman avatar weshouman commented on August 24, 2024

This issue was mainly due to a confusion, if something would be updated may be it's the doc part.
Scenario:

  • A stub function was being assigned to a stub object.
  • After finishing the tests all the stubbed methods were being restored.

Issue:

  • The restore() method is undefined for stubs that are created with the default constructor ( note: we can only stub using the default constructor in this case, as stub(obj, 'function') requires the 'function' to be predefined).

Fix:

  • Check if the restore() is defined for the stubbed method before calling it.

from sinon.

fatso83 avatar fatso83 commented on August 24, 2024

Ah, I get you. There is no way to fix this, as a function in itself does not know which name it is assigned to, so a restore function would not know what to do with this.

from sinon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.