Giter VIP home page Giter VIP logo

Comments (6)

sio avatar sio commented on May 28, 2024

Yeah... macOS does not ship GNU coreutils by default, you need to install them via brew or in some other way. That makes me wonder, which make implementation is shipped by default (if any)? Could you paste the output of make --version?

I am hesitant to change installation instructions as you suggested, because calling Perl to calculate a hash sum instead of using coreutils feels deeply wrong to me. I think I'll add a note about coreutils and mention your workaround too.

from makefile.venv.

MunchDev avatar MunchDev commented on May 28, 2024

Output for make --version:

GNU Make 3.81
Copyright (C) 2006  Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i386-apple-darwin11.3.0

By the way, may I ask why not using coreutils is bad?

from makefile.venv.

sio avatar sio commented on May 28, 2024

Oh, it's not bad and it's not about coreutils per se. It just feels wrong to me to call into interpreted language for a number-crunching task when there exists a compiled binary tool for the same purpose.

from makefile.venv.

MunchDev avatar MunchDev commented on May 28, 2024

Personally, I don't think the performance loss is really significant, since the file Makefile.venv isn't really big. Yet, if shasum is shipped with all Linux distributions plus MacOS, so why not use it?

Apologise if I ask a stupid question!

from makefile.venv.

sio avatar sio commented on May 28, 2024

Your question is not stupid :) I'm being somewhat irrational here, you're right about performance being similar for small files. I'm being too much of a GNU fanboy :)

I'll look into how ubiquitous Perl currently is. I'll check if common Docker containers ship with Perl included, since it's the only scenario I could think of that's questionable. Then I will take a 1-2 day pause to let this sink in, but yeah, the rational thing would be to agree with you.

from makefile.venv.

sio avatar sio commented on May 28, 2024

My intuition proved correct. shasum is not included into any of base Docker images (Alpine, Debian, Ubuntu, Centos). Even though shasum is part of Perl package, deb-based distros provide a smaller perl-base (without shasum) which is enough for OS tools to function.

On the other hand, GNU coreutils are present in each of those images.

I'll add a note about macOS to README now, but the instructions should stay unchanged.

from makefile.venv.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.