Giter VIP home page Giter VIP logo

Comments (11)

adubovikov avatar adubovikov commented on September 18, 2024

please make modification and a merge request. We will accept it ASAP.
the ideally will be create a config file i.e. /etc/homer/rotate.conf and read this information from there.

from homer-api.

michaelarnauts avatar michaelarnauts commented on September 18, 2024

Okay, but in the past, the configuration files were like preferences_example.php, and now they are moved to preferences.php. This makes it impossible for those files to be excluded in a .gitignore.
According to the commit message, this was done for some packaging changes.

from homer-api.

lmangani avatar lmangani commented on September 18, 2024

@michaelarnauts just thinking out loud here, if the only changes are configuration files wouldn't simply stashing and restoring after a pull should do the trick? git stash && git pull && git stash pop

This being said a .gitignore config file as Alexandr suggest could do the trick and provide details for all scripts/files requiring them with some work or via an update script.

from homer-api.

michaelarnauts avatar michaelarnauts commented on September 18, 2024

@lmangani true, but that tend to give conflicts when changes in those files are also made.

The cleanest way is to have a configuration.php.example file, and upon installation, copy that to a configuration.php file, what is ignored trough a .gitignore. At least, that's how most projects do it. I just don't know how that relates to the packaging changes that are being made the in the last weeks/months.

from homer-api.

lmangani avatar lmangani commented on September 18, 2024

We will quickly discuss the package implications and how to implement this best

from homer-api.

lmangani avatar lmangani commented on September 18, 2024

@michaelarnauts implemented, the filenames are restored to their correct names now as they were - thanks for raising this and please confirm back to close the issue

from homer-api.

michaelarnauts avatar michaelarnauts commented on September 18, 2024

@lmangani you need to remove the configuration.php and preferences.php, and add those to .gitignore. Otherwise, they are still marked as changed on a git pull.

This also doesn't resolve this issue, since all scripts still need to be changed. This issue is to have one place where the configuration is stored.

from homer-api.

adubovikov avatar adubovikov commented on September 18, 2024

sorry, but we did it. Please check homer-api git

from homer-api.

michaelarnauts avatar michaelarnauts commented on September 18, 2024

@adubovikov sorry, I only checked the latest commit :)

I think we still need a way to have one configuration file that is easy parsable with PHP and Perl.

from homer-api.

adubovikov avatar adubovikov commented on September 18, 2024

the configurations for php and for rotation scripts should be separated,
because you can have multiple DBs, but only one web UI.

so, the idea to create one config for rotation scripts is not bad, but only
for rotations scritps.

On 7 January 2016 at 15:26, Michaël Arnauts [email protected]
wrote:

@adubovikov https://github.com/adubovikov sorry, I only checked the
latest commit :)

I think we still need a way to have one configuration file that is easy
parsable with PHP and Perl.


Reply to this email directly or view it on GitHub
#66 (comment)
.

from homer-api.

adubovikov avatar adubovikov commented on September 18, 2024

testers are welcome

https://github.com/sipcapture/homer-api/tree/master/scripts/new

from homer-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.