Giter VIP home page Giter VIP logo

Comments (7)

sipsorcery avatar sipsorcery commented on May 21, 2024

I've never come across out of band DTMF in the will I'm sure it's out there given there are RFC's for it (RFC2733 and RFC4733) but I suspect it might be restricted to inter-carrier networks. Had a brain fade when I originally wrote that, RFC2833 is the default DTMF mechanism for a lot of soft phones and media servers.

The best approach is to use DTMF via SIP Info. That mechanism puts DTMF events into SIP INFO requests and means there's no extraction from audio RTP packets required.

If you do need to go down the out of band path then there's nothing specifically useful in the sipsorcery code base as I've never worked with it.

from sipsorcery.

rwil02 avatar rwil02 commented on May 21, 2024

Lightning fast :)
I was just looking at this:
https://www.voip-info.org/wiki/view/SIP+DTMF+Signalling

Which implies to me that "telephone-event" might actually arrive in the same RTP Channel and so it might be a matter of replacing ProcessRTPPackets?

If I pull https://github.com/sipsorcery/sipsorcery/tree/master/sipsorcery-core will that match 1.5.6?
I might go through and add a pile of logging in there and test if the DTMF packets are coming through.

from sipsorcery.

rwil02 avatar rwil02 commented on May 21, 2024

Just to say I "think" I've managed to submit a change to you that allows you to intercept an RTP Packet and choose to handle it first (such as for handling DTMF)

Change was in RTPChannel.cs which I've attached, just in case.

RTPChannel.zip

from sipsorcery.

sipsorcery avatar sipsorcery commented on May 21, 2024

You should hook up the RTPChannel.OnFrameReady event. There's no need for your additional ProcessRTPPacketsCustom property.

The additional advantage of using the OnFrameReady event is that you will get full RTP frames rather than partial ones. If your DTMF was spread across multiple RTP packets you'd need the full frame to be able to extract them.

from sipsorcery.

rwil02 avatar rwil02 commented on May 21, 2024

Yeah, that got it.
Looks like for End/Reserved/Volume I had to reverse the bit order (IsLittleEndian = true).
Does that sound right to you?

from sipsorcery.

rwil02 avatar rwil02 commented on May 21, 2024

Only other thing I've got is a Before Send Request/Response event added to SIP Transaction because the server I'm talking to isn't happy with a blank "user" in the contact field for some reason.
SIPTransaction.zip

I couldn't find any other way to gain access to the "OK" response.
I've tried to attach it here.

from sipsorcery.

sipsorcery avatar sipsorcery commented on May 21, 2024

RTP events are now available. An example program and explanatory article are also available.

from sipsorcery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.