Disable TextFormatter key sorting about logrus HOT 8 CLOSED

+1 here, it should not be forced.

from logrus.

Aye, could be an option like ForceColors.

from logrus.

yeah, something like SortFields

from logrus.

I'll happily accept a patch

from logrus.

I looked in to this and in order to do this we probably need to add another WithFields*-method since logrus.Fields{} is of type map[string]interface{}, which by nature is "random".

I have been playing around with making WithField() either take a ...interface{} and thus be able to handle multiple key/value pairs (which we could keep sorted) or to just add a WithFieldList() not to make people confused with the name being singular.

Any input on what would feel most natural?

from logrus.

Fixed in 538395b

from logrus.

The solution isn't this easy since entry.Data is of type Fields (map) and maps are random by nature.

Code:
logrus.SetFormatter(&logrus.TextFormatter{DisableSorting: true})
logrus.WithFields(logrus.Fields{"one": 1, "two": 2, "three": 3, "four": 4}).Info("one")
logrus.WithFields(logrus.Fields{"two": 2, "one": 1, "four": 4, "three": 3}).Info("two")
logrus.WithFields(logrus.Fields{"three": 3, "four": 4, "two": 2, "one": 1}).Info("three")

Output of run 1:
INFO[0000] one one=1 two=2 three=3 four=4
INFO[0000] two one=1 four=4 three=3 two=2
INFO[0000] three one=1 three=3 four=4 two=2

Output of run 2:
INFO[0000] one one=1 two=2 three=3 four=4
INFO[0000] two two=2 one=1 four=4 three=3
INFO[0000] three one=1 three=3 four=4 two=2

Notice how they now are random instead of sorted. We would have to change from the map type to a slice in order to implement this for real. Where they align correctly to their input is just pure luck.

from logrus.

Yes, that's what I expected, most aggregators are fine with that—I didn't do a full reimplementation with a slice. I'd happily accept a patch that does.

from logrus.