Comments (7)
@Sebobo Not sure what we can do here. What does the dummy image controller return instead of the image I would expect an error message instead of the image plus some meaningful info in the logs.
I understand that its will be hard to spot as the browsers will include the dummyimage as a src and thus the error is hard to spot. But i am not sure how to circumvent this.
I did not reproduce the error since i have no vips at hand If no status 500 is returned i would consider it a bug and work in this.
from sitegeist.kaleidoscope.
How about catching the exception and return the link to a static image/svg that contains some "rendering error" text?
Then it's immediately visible what's going on, and maybe we could even make it configurable.
from sitegeist.kaleidoscope.
@mficzel A configuration for vips looks like this:
Neos:
Imagine:
driver: 'Vips'
enabledDrivers:
Vips: true
Gd: true
Imagick: true
Media:
image:
defaultOptions:
# The Vips driver does not support interlace
interlace: ~
Perhaps it could solve the problem to check if the driver is Vips and get the enabled Drivers (In this case Imagick
) and use this library. Would this be a way to go?
from sitegeist.kaleidoscope.
If this is a problem more than one person has i agree the best way is to integrate a default error image and a try-catch block.
If anyone provides a pr for this i can review it.
from sitegeist.kaleidoscope.
In a Ngnix environment, it is possible the set the FLOW_CONTEXT based on the requested path. On Apache, I couldn't get it running. In those circumstances, I can't use this Package with vips and Apache.
- Would it possible to include the behavior I explained above?
- Or why not create an SVG? It would be a) faster and b) would not use any library
from sitegeist.kaleidoscope.
@jonnitto did you try recent versions of kaleidoscope? They should fallback to an error image at least when the generation of dummyimages yields an error
from sitegeist.kaleidoscope.
Yes, this error image works, but I would prefer the dummy picture with the text/dimensions
from sitegeist.kaleidoscope.
Related Issues (20)
- Thumbnails Presets with dots are not resolved
- Image Scaling only works if width is given HOT 2
- Add support for Variant Presets HOT 2
- Missing Eel Helper `setText` HOT 4
- Image Crop/Scale breaks GIF animation HOT 2
- Get dimensions or ratio from an AssetImageSource or DummyImageSource HOT 1
- ResourceImageSource only with path is broken
- Compatibility with Neos 7
- How to define a max width + height? HOT 1
- Don't render srcset paths that are bigger than the original image HOT 5
- Kaleidoscope doesn't work with Vips HOT 3
- src not allowed in Source for images HOT 2
- Add generic `attributes` to Image and Picture
- useVariantPreset only works for ImageVariant
- withVariantPreset with DummyImage source leads to fatal error
- Runtime Cache for src() HOT 1
- Add a "fetchpriority" property to the API
- Rendering srcsets with images for multiple breakpoints broken without prop "sizes"
- Missing option `quality`
- Clone method cannot declare a return type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sitegeist.kaleidoscope.