Vantage Social Media Widget: Tel field to accept URL about vantage HOT 5 CLOSED

Assume that would mean just checking for a field with numbers dashes and a
plus? There must be a decent PHP phone number checking snippet out there.
On Mon, 06 Jun 2016 at 7:54 PM Andrew Misplon [email protected]
wrote:

@adiraomj https://github.com/adiraomj Sorry for missing this. Please,
can we make the Tel field a bit smarter, just like the email field? Can
we make it accept a URL if one is entered and only prepend tel if a phone
number is detected?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#73, or mute the thread
https://github.com/notifications/unsubscribe/ABExy426vAekDXhHsfkLuPkZA1tsq3a1ks5qJF7vgaJpZM4IvJl0
.

from vantage.

What we can do is use PHP's FILTER_VALIDATE_URL to validate url. If it fails we can display tel:. What do you think?

from vantage.

I'm cool with doing that way around. @gregpriday ?

from vantage.

@Misplon I just went through out code again. The logic does use FILTER_VALIDATE_URL to check for a url.

However for FILTER_VALIDATE_URL to return true, the url must use http:// or https://.

So for example:
https://siteorigin.com - Passes
http://siteorigin.com - Passes
siteorigin.com - Fails

https://github.com/siteorigin/vantage/blob/develop/inc/widgets.php#L321

from vantage.

@adiraomj My bad for not testing that. Cool, this is fine, let's leave it. Thanks man.

from vantage.