Comments (2)
You are right; we are following different standards. This has various reasons, one of which is that I normally use a different standard (which is based on http://framework.zend.com/manual/1.12/en/coding-standard.html). However, given the enormous amount of work that also needs to be done I prefer not to worry about this too much.
I'll accept both K&R or ZF code; if we refrain from refactoring each-other's code just for consistency of whitespace that'll work fine. Whitespace is easy to correct automagically afterwards and I don't want it getting in the way of completing this rewrite.
from pfsense.
Sounds good. Can we put this somewhere in the README for clarity for new contributors? We should also add that we don't expect any logic rewrite or at least some mention of the scope of the project.
from pfsense.
Related Issues (20)
- How to group 10 checkboxes as a single 'value' HOT 5
- Force correct initial state for toggleable checkboxes HOT 1
- Form.class no longer accepts boolean HOT 1
- do_input_validation in guicondic.inc does not handle array form values
- Inline form layout on /status_graph.php HOT 1
- Replace td's with th's in thead
- File chooser ("Browse") control has alignment issues HOT 2
- Simple php/html validations we can do after nearing completion
- Forms with a single input, which layout HOT 2
- Multi-select input size HOT 3
- Unable to provide value to textarea
- Feature request - button type HOT 6
- vpn_pptp.php et al no longer needed HOT 1
- Text area form introduces unwanted white space HOT 3
- Remove cancel buttons HOT 4
- Unable to dismiss notices
- Upstream security issues HOT 2
- $group->enableDuplication() fails if max is specified
- enableDuplication() Delete button ignores confirmation
- enableDuplication() does not add "Clone" button
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pfsense.