Giter VIP home page Giter VIP logo

Comments (3)

niktek avatar niktek commented on May 22, 2024

Pretty sure this is an issue with line 48 in ListItem.svelte and that it should be reversing the ternary operands to:
parentTag === 'nav' ? elemItem.click(): elemItem.querySelector('a').click();

If parentTag is nav then the emitted tag (and therefore itemElem is a and hence querySelector('a') will always fail as it looks for an anchor inside itself. However, when parentTag is not nav, is there some benefit to trying to hit the anchor that may be nested in a slot - potential navigation ?? if not then the ternary can disappear and it can be just a elemItem.click()

This change makes highlighting via keyboard work across the board.

from skeleton.

niktek avatar niktek commented on May 22, 2024

LHS menu issues are solved in Safari by editing settings:
image

Why it worked for the components/lists/ page when this is off makes little sense.

from skeleton.

endigo9740 avatar endigo9740 commented on May 22, 2024

Ugh, that's a frustrating default setting for Safari! Apple is using on the ball with user-centric defaults, so that's a big miss on their part. Hopefully folks that need this setting know about it!

Per the keypress event, you're correct, it should not need to query within itself. It should just just trigger click on itself if it's part of a nav list set. I've dropped this in in favor of a simple if statement. Good catch!

Fixed per: 3d3f9bd

(also wohoo our 700th commit!)

from skeleton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.