Props are not updated in Modal Settings about skeleton HOT 4 CLOSED

@sorae42 May I ask how you misunderstood the docs? I ran into the same problem you seem to have had and was not able to find out how buttonPositive should be used. My use case is to change the confirm button of a confirm modal to a red color for destructive actions, but as you mentioned, that is currently not possible according to the ModalSettings type definition.

Oh, you are supposed to use these in the <Modal> tag that you set up in +layout.svelte. LIke so: <Modal buttonPositive="...">.

from skeleton.

It seems that I misunderstood the docs. Sorry in advance.

from skeleton.

Yep, props go on the component definition, params go into the ModalSettings object. We have automated documentation of props, but unfortunately this is not possible for params. We may end up manually documenting ModalSettings in the near future. For now here's a reference:

https://github.com/skeletonlabs/skeleton/blob/master/packages/skeleton/src/lib/utilities/Modal/types.ts#L14

We aim for parity between params and props wherever we can. Unfortunately it looks like we have a few that aren't represented yet, such as a buttonPositive.

@dnnsmnstrr @sorae42 if you have a solid use case for this, feel free to reference this thread and post and create a feature request ticket. I'd be happy to look at adding these soon. Thanks!

from skeleton.

@sorae42 May I ask how you misunderstood the docs? I ran into the same problem you seem to have had and was not able to find out how buttonPositive should be used.
My use case is to change the confirm button of a confirm modal to a red color for destructive actions, but as you mentioned, that is currently not possible according to the ModalSettings type definition.

from skeleton.