Review "RestProps" spread method for arbitrary attributes about skeleton HOT 3 OPEN

I don't think it's an unreasonable expectation that class be exposed and implemented on root elements. We're making building blocks, and keeping them to the regular HTML spec makes them predictable. We can always remove the class attribute via Omit<HTMLAttributes<HTMLDivElement>>, 'class'> to keep people using the classes convention if we decide to go all in on that, though.

Regarding duplicating the props, the last one wins- so just make sure that our spread operator is at the top of the element, and it'll be overridden properly.

from skeleton.

Yeah we're pretty committed to the classes attribute because it allows for more than just the parent. Any children can follow the same pattern. So the mix of the standard class attribute + classes can and would cause some confusion I'm sure.

https://next.skeleton.dev/docs/resources/contribute/components#props

Though thinking it out, I don't think it would cause any real harm, but again, that's what I'll need to test to verify.

from skeleton.

I agree with @ryceg. Using class instead of classes will probably be less confusing. I've already used the techniques decribe above for the Listbox PR: #2754 without realizing this issue was open. I did exactly what was described, spread the attributes and override the one's we use internally. Especially with the zag discussion coming up (#2777) it would be nice if we can resolve this before going all in into porting again.

from skeleton.