Menu insert index about sketchup-stl HOT 8 CLOSED

I wondered how many seconds it would take for you to notice that. ;)

This was an added feature in a recent maintenance release, so only up to date clients will have this.

It occurs to me that this whole block needs to be wrapped in a version check. I'm not sure what behavior would be on older versions of SketchUp.

from sketchup-stl.

No need for version checking - we can use feature checking:

SketchUp 6:

Sketchup::Menu.instance_method( :add_item ).arity
# > 1

SketchUp 8 M4:

Sketchup::Menu.instance_method( :add_item ).arity
# > -1

So one can do:

if Sketchup::Menu.instance_method( :add_item ).arity == 1
  UI.menu("File").add_item("Export STL...")
else
  UI.menu("File").add_item("Export STL...", insert_index)
end

So the version that support it accepts any number of argument, but the old ones only accepts one.

On the other hand - not all SketchUp classes works like this. UI.menu accepts any number of arguments without caring. UI.menu('Plugins', 123, 456, 789) doesn't raise any errors. (I checked to see if one could pick a sub-menu...)

from sketchup-stl.

Yeah, if it works in older versions, then awesome. Nice trick with the arity check! I learn something new every time you guys post.

from sketchup-stl.

I just pushed a guard for it.

from sketchup-stl.

Great catch Thom! Hehe we learn new things when you post as well scott :)

On Tue, Oct 30, 2012 at 8:55 AM, Thomas Thomassen
[email protected]:

I just pushed a guard for it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-9910966.

from sketchup-stl.

Closing this one now. Feature guard has been pushed to master.

from sketchup-stl.

The thing about feature checking is that you don't always know who added or changed the feature. It's possible that some feature has been implemented poorly by a "rogue" plugin".

from sketchup-stl.

You can test on a plain vanilla installation.

from sketchup-stl.