Giter VIP home page Giter VIP logo

Comments (14)

scottlininger avatar scottlininger commented on June 5, 2024

A new rbz would be great.

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

Especially since this blog post: http://sketchupdate.blogspot.no/2013/01/stls-for-3d-printing-in-and-out-of.html

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

@jimfoltz you fixed some things as well, such as a bug in my cleanup code when the geometry was not imported into a group.

Can we merge and apply this before releasing an update?

from sketchup-stl.

jimfoltz avatar jimfoltz commented on June 5, 2024

I made a pull request with only the fix but none of the other changes in the series. Not sure what I was doing in my master branch.. 😕

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

What about the other stuff? You don't want to include that?

from sketchup-stl.

jimfoltz avatar jimfoltz commented on June 5, 2024

I only included a bug fix so a new rbz could be generated. I am not sure it's the right time for adding in-progress (un-tested) features.

from sketchup-stl.

scottlininger avatar scottlininger commented on June 5, 2024

Seems like I should merge the bug fix, then we can consider other changes on other requests. Any objections?

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

How are we doing this update? Add a new RBZ in the repo itself? Or upload it a place where it can be downloaded?

from sketchup-stl.

scottlininger avatar scottlininger commented on June 5, 2024

I'd say replace the .rbz in the repo root with a new one, probably with a new revision number, like sketchup-stl-1.0.1.rbz

We'd want to rev the extension version, too.

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

How's the version numbers set?

I've always seen versions like:

Major number: increment for major feature change, addition or core rewrite
Minor number: Feature added or improved
Revision number: small bug fixes.

I'd say this is at least 1.1.0 - could have been version 2.0 due to pretty much complete rewrite and wrapped up in a new namespace. But we have a few unresolved issues where I'd imagined we'd complete before calling it a 2.0.

I set up some milestones a couple of weeks ago. Be interesting to hear what you lot think.

Just nobody say we do versions like Firefox or Chrome...

from sketchup-stl.

scottlininger avatar scottlininger commented on June 5, 2024

Good points. I'd say this is 1.1.0, and a candidate for 2.0.0. We probably should scrub the feature request list and see what belongs in a 2.0.0 release.

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

My suggestion for Milestone 2.0: https://github.com/SketchUp/sketchup-stl/issues?milestone=1&state=open

And 2.1: https://github.com/SketchUp/sketchup-stl/issues?milestone=2&state=open

from sketchup-stl.

Aerilius avatar Aerilius commented on June 5, 2024

Oh, and people start hard-linking to the 1.0.0 file.

from sketchup-stl.

thomthom avatar thomthom commented on June 5, 2024

Ok, Jim's fix is now merged. Would have been nice to have #54 fixed as well though.

from sketchup-stl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.