Giter VIP home page Giter VIP logo

Comments (12)

kjbetz avatar kjbetz commented on May 17, 2024 3

I'd like to start taking a look at this and offer some help. I worked on a project for myself that implemented a free UI for the PolicyServer... would be good to implement that all together. I'll start taking a look around of what you have already. Awesome stuff!

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024 3

I am working on API:
https://github.com/skoruba/IdentityServer4.Admin/tree/feature/api
I am using the shared business logic from MVC project, but with new mapping for API dtos.

Currently still in progress, but with high priority. :)

from identityserver4.admin.

ekjuanrejon avatar ekjuanrejon commented on May 17, 2024 2

@skoruba why can't the business logic of the mvc and the api be shared?

On another note. I see that mvc uses a bit of reflection. Not how how it will play with the api and swagger.

from identityserver4.admin.

JimBobSquarePants avatar JimBobSquarePants commented on May 17, 2024 2

Ah fantastic @skoruba ! I'll have a good look asap.

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024 1

Thanks for your feedback, I will work on it. :)

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024 1

Done, please take a look at new release. 👍🏼
Thanks.

from identityserver4.admin.

ekjuanrejon avatar ekjuanrejon commented on May 17, 2024

hello @skoruba

any plans on this?

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024

Hi @ekjuanrejon
In the future yes, but if you want to start with this task, feel free send a PR. :)
Thanks!

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024
  • Create projects:
    • Skoruba.IdentityServer4.Admin.Api
    • Skoruba.IdentityServer4.Admin.Api.BusinessLogic - There will be great to reuse the existing repositories (#250) and create new services for API, including new Dtos etc.

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024

That is great question, I think some of Dtos are very specific for views in MVC app, thefore I am thinking about this separation.
But you are right, maybe it would be fine - create shared business logic layer for both - mvc and api. I will try to consider it.
Good point. :)
Which part of code with reflection do you mean?
Thanks!

from identityserver4.admin.

JimBobSquarePants avatar JimBobSquarePants commented on May 17, 2024

The missing APIs are the only feature that devalues this product from competition. The company I work for are unfortunately having to evaluate another product because we need those APIs and are under so much time pressure we cannot currently dedicate the time to PR the functionality. 😞

👍 on reusing logic.

from identityserver4.admin.

skoruba avatar skoruba commented on May 17, 2024

Great, if you want to help, it would be perfect. 👍

from identityserver4.admin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.