Giter VIP home page Giter VIP logo

Comments (3)

djcass44 avatar djcass44 commented on May 9, 2024

Can you clarify a bit, do you want to replace the Browser/HttpFetcher or add an additional one?

from skrape.it.

skrapeit avatar skrapeit commented on May 9, 2024

hey,
the httpFetcher is currently using jsoup to make http requests.
https://github.com/skrapeit/skrape.it/blob/master/src/main/kotlin/it/skrape/core/fetcher/HttpFetcher.kt

we want to use KoHttp instead because it ships with a bunch of nice features like async requests and use jsoup for the document parsing only.

one thing to notice:
currently it is possible to add validateTLSCertificates and maxBodySize parameters to the request. since I don't think this is possible with HoHttp this ones can be removed from Request if it is not possible to manage this behavior with KoHttp.

The other Request options should be working further on.

since KoHttp provides different functions to handle certain http-request verbs (e.g. httpGet(), httpPost()) and scrape{it}'s approach is to pass the http verb as an parameter (Enum) it looks like we will need a mapping from org.jsoup.Connection.Method (which is the Enum that is currently used for method field in Request.kt) or even better providing an Enum our own and get rid of the jsoup one.

from skrape.it.

djcass44 avatar djcass44 commented on May 9, 2024

I just opened #64, let me know if it's what you're looking for

from skrape.it.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.