Comments (7)
Why does 3 fail?
from sktime-dl.
It might be possible to get 3 to work. It failed when just doing a straight swap back to initialising the attributes in the derived class's init:
E AssertionError: Estimator LSTMRegressor should not set any attribute
apart from parameters during init. Found attributes ['is_fitted', 'random_state'].
../../anaconda3/envs/sktime_env/lib/python3.7/site-packages/sklearn/utils/estimator_checks.py:2413: AssertionError
- Is there somewhere else appropriate where
self.random_state
could be initialised? - Would it be reasonable to initialise
self.is_fitted
in thebuild_model
function?
Either way, initialising those attributes elsewhere still leaves this error:
../../anaconda3/envs/sktime_env/lib/python3.7/site-packages/sklearn/utils/estimator_checks.py:427: in check_estimator
validate_X(X)
E ValueError: X must be a pandas.DataFrame, but found:<class 'numpy.ndarray'>
../../anaconda3/envs/sktime_env/lib/python3.7/site-packages/sktime/utils/validation/supervised.py:26: ValueError
I.e. this sklearn check requires the fit function to work with an input numpy array X.
It looks like this point could be rectified easily enough.
from sktime-dl.
Okay, yes, everything else could be initialised in fit, self.is_fitted = True
could simply be at the end of the fit method. Random state, when passed to the constructor should simply be stored, i.e. self.random_state = random_state
but checked and modified only in fit check_random_state(self.random_state)
from sktime-dl.
Hi @mloning , @james-large , I hope you are both well. I'm in a position where I could pick up this issue now. Are you around to be able to review and merge once done?
from sktime-dl.
Hi @Withington, yes, I'm currently in the process of refactoring sktime, and will be here to review changes
from sktime-dl.
Hello all, good timing, was about to focus in this for a while again. Have another couple of networks to implement, and we can just have a general sitrep, I'll make an issue for it
from sktime-dl.
closing in the tidy up, feel free to raise an new issue after the restructure
from sktime-dl.
Related Issues (20)
- [BUG] Can't import the CNNClassifier from sktime_dl.deeplearning HOT 6
- [BUG] Examples don't run HOT 1
- Migration to `sktime`
- Add flaky for forecasting tests HOT 2
- will your cod work when data is mixer of continues and categorical variables for each time sample? HOT 2
- sktime-dl examples? HOT 3
- ModuleNotFoundError: No module named 'sktime_dl.deeplearning.lstm' HOT 4
- Question: Normalization required? HOT 4
- Forecasting reduction capabilities/tests HOT 3
- Update examples notebooks to support sktime 0.4.1 HOT 2
- [BUG] ImportError: cannot import name 'tabularise' from 'sktime.utils.data_container' HOT 2
- Loss function in CNNClassifier HOT 2
- [BUG] Problem with sktime-dl installation; cannot import e.g. sktime_dl.deeplearning HOT 19
- [BUG] ImportError: cannot import name 'tabularise' HOT 1
- [BUG] ModuleNotFoundError: No module named 'sktime.utils.data_container' HOT 3
- Checklist for Refactoring CI/CD of sktime-dl HOT 5
- [BUG] ModuleNotFoundError: No module named 'sktime.utils.data_container' HOT 3
- Refactor into classifier/regressor/network structure HOT 1
- [BUG] failing tests in test_regressors.py for LSTMRegressor HOT 1
- [DOC] Update comment style to comply with sktime format HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sktime-dl.