Balloon crashes on showing, BadTokenException about balloon HOT 13 CLOSED

@dpeters-ipc Could you please in Fragment try to use viewLifecycleOwner?

from balloon.

@egorikftp
I will check about it more and I will try to fix it in the next release.
Thank you for your issue :)

from balloon.

Don't use the applicationcontext for building the balloon. Instead, use your activity's context.

from balloon.

I use getContext() of Fragment

from balloon.

As you can see from the exception, the balloon could not get the activity's context. It should be called in onViewCreated (after onCreateView) and it will be better to check the activity is still alive.

val activity = getActivity() ?: return
showAsDropDown..

from balloon.

Hi, I tried this in a new release, but it wasn't enough. The crash still occurs.
I will add !activity.isDestroyed() && !activity.isFinishing() in the next release.

But it could still happen because you call PopupWindow.showAsDropDown from a Handler. This is asynchronous and the activity-state might have changed. So some checks in the Balloon code would be an improvement for stability I think.

from balloon.

@dpeters-ipc
Do you use setLifecycleOwner using the activity's lifecycle as a parameter?

from balloon.

I'm using setLifecycleOwner(this) where this is the Fragment instance

from balloon.

@dpeters-ipc
Hi, I changed the Handler using the main looper in the new version 1.1.6.
If the same issue will happen and if the crashes are serious, the dismissWithDelay functionality will be removed. Thank you :)

from balloon.

It's included in the new version 1.1.8.
Thank you for your issue :)

from balloon.

@skydoves Looks like with viewLifecycleOwner we have crash in the latest version using by balloon() delegate.

java.lang.IllegalStateException: Can't access the Fragment View's LifecycleOwner when getView() is null i.e., before onCreateView() or after onDestroyView()
at androidx.fragment.app.Fragment.getViewLifecycleOwner(Fragment.java:353)

from balloon.

Hi, @egorikftp.
As you can see from the log, I think the balloon is used before onCreateView() or after onDestroyView().
Could you please give me more details about your use cases?

from balloon.

I call balloon after onViewCreated(), not reproduced on 1.1.7 version.

Source code:
https://github.com/egorikftp/Lady-happy-Android/blob/5fbfc4c2d43b6a725a26d7c1edb290881de46da4/sources/feature/catalog/src/full/java/com/egoriku/ladyhappy/catalog/subcategory/presentation/fragment/SubCategoryFragment.kt#L37

class SubCategoryFragment : Fragment(R.layout.fragment_catalog) {

    private val binding: FragmentCatalogBinding by viewBinding()

    private val viewHolderBalloon by balloon(ViewHolderBalloonFactory::class)

    private var subcategoryController: SubCategoryController by Delegates.notNull()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)

        subcategoryController = SubCategoryController(
                onCatalogItemClick = {
                    
                },
                onTrendingClick = {
                    viewHolderBalloon?.showAlignLeft(it)
                }
        )
    }
}

from balloon.