retrofit-adapters-result nullable body about retrofit-adapters HOT 10 CLOSED

square/okhttp#7005 is about request body not response body.
https://github.com/square/retrofit/blob/master/retrofit/src/main/java/retrofit2/Response.java#L151 response body are always nullable

i will made some tests

from retrofit-adapters.

@xanscale Thanks for your contribution. It will be contained in the next release!

from retrofit-adapters.

Hey @xanscale, I'm a little bit confused about the terminology. Do you mean the empty body (Code 200 responses, right?)

from retrofit-adapters.

Additionally, what are the benefits of using a nullable body over the Unit type for the empty body?

from retrofit-adapters.

i have a service that can return body or not, in detail

• 200 with body
• 204 without body

Unit are used when you know that there is no body (or you dont care on it)

with my PR it works with both Foo? and Unit.

• Unit can be used in caso of there isn't body or don't care about body
• Foo? can be used in case of optional body

from retrofit-adapters.

@xanscale Btw is there a meaningful difference between an empty body and a nobody?

from retrofit-adapters.

@skydoves response body are OPTIONAL! same call can be with response body or not based on USER status.

from retrofit-adapters.

@xanscale I'm unsure if #18 works well because fundamentally OkHttp doesn't support NULL body yet: square/okhttp#7005.

And can we build any unit test cases for the nullable body similar to this? https://github.com/skydoves/retrofit-adapters/blob/main/retrofit-adapters-result/src/test/kotlin/com/skydoves/retrofit/adapters/result/ResultCallTest.kt#L87

from retrofit-adapters.

I got it. Thanks for the details!

from retrofit-adapters.

pushed unit test

from retrofit-adapters.