Comments (7)
@danielmhair Same boat as you, only error present.
from parchment.
I'm getting this also when I installed ngx-quill
, which installs quill
and @types/quill
. It only happens when my tsconfig.json
file has strict: true
. Setting it to strict: false
fixes this. However, I need strict: true
on my project. So I made a pull request. But to explain in detail, my error is:
node_modules/@types/quill/node_modules/quill/parchment/src/collection/linked-list.ts(9,5)
For this PR, I had to change all undefined
to null
. All tests are passing. Please let me know if this is not what you are expecting with the linked list. I understand that setting it to null
instead of undefined
could cause unintended issues, but since its passing tests, I'm assuming the unit tests are covering our bases?
Here is the pull request: #43
from parchment.
Hey @jhchen, after you merged master, I tried updating my version of parchment
, but it seems to not receive the updates. The version that it installs is 1.1.3
. I saw that master has the same version number. Have the changes not been published to npm yet?
from parchment.
@danielmhair seeing the same issue as you.
from parchment.
@danielmhair I was going through the same thing and was about to submit a PR as well, seems it is important to allow developers using strict: true
to use the types free of error. Beat me to it!
from parchment.
Sounds great @juanparadox! To fix it, I set strict: true
initially, and there are a ton more errors that come up from, but since this was the only error that comes up on my end, I felt no need to do more of it. I have tested these changes in my project and it does seem to fix the build errors.
from parchment.
No it's not pushed. There's some more diligence I need to do before publishing so I'll try to get to that this weekend. FYI for any project that uses version numbers you can look in the commit log and check if the change you are looking for is before or after the version bump.
from parchment.
Related Issues (20)
- Paste options for plain text content
- Inline Embed not working in 2.0 branch
- Is this condition of `uiNode` a typo? HOT 2
- registering a new blot does not add it to the allowed children of the scroll object
- block
- How cloud I understand Scope and What is the meaning of & operator between Scope and another Scope
- How to set editor content with html style
- Make v2 the default branch HOT 1
- register Blot unsucessfully
- [Question] Is it possible to define how a blot is serialized ? HOT 1
- How to add custom inline blot (or any blot whatsoever)? HOT 2
- Where can I find the old version commit? HOT 1
- Incorrect descendant typing (ts2769) HOT 1
- Adding a custom Blot HOT 1
- Remove Byte Order Mark (BOM) characters from Blot HOT 3
- Quill editor removes inline style margin-left on loading content
- the img tag is not closed HOT 1
- re-export classes from quill-delta and parchment
- How do we replicate the functionality inside a blot's `replace` function?
- Support ClassAttributor if prefix == ''
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parchment.