Comments (5)
Separate registries would really help us in our use case with multiple editors on a page, each needing different formatting options
from parchment.
Sadly the linked branch is far from near complete. By my estimate it is still in the very beginning stages where the design is still not vetted as I already mentioned in slab/quill#1101. Skipping the design of the solution before implementation will lead to the need to implement multiple times. Invest the time to design properly and you will only need to implement once (and the typing will go very quickly).
Also stated in the Contributing Guide is that API modifications undergo the most scrutiny. It is not enough to be bug free or backwards compatible, it also needs to be the best possible solution and API design to be merged into core.
So if you want to make progress on the PR, spend a much larger portion of time thinking about the API, how it interacts with existing APIs and features and how your solution will behave, and then propose that solution.
If your motivation was just to use this feature, then the simplest solution is just maintain your own branch or fork, so you do not have to meet the standards Quill core must meet given its wide audience.
from parchment.
I've been watching this request for a while, and based on years of working with rich text editors for client projects, I think it would be best practice to isolate each editor's formatters - or at least provide an option to do so. Most editors on the market, open source or commercial, do this by default as it allows an editor to be used in different use cases on the same page.
My experience with Quill has had some surprises. Formatters loaded for one editor affect all editors, allow pasting of content into another editor that may not have appropriate toolbar buttons loaded for the content. There's currently no way to prevent an editor from supporting features intended for another editor on the same page. Making this change (merging this PR, or doing something else) would help modernize an otherwise strong product.
from parchment.
@jhchen From my perspective, the design is a fairly common convention, using class instances rather than attaching state at the module level...but I wasn't present for the initial design and development of the project, so it's difficult to anticipate the direction of the code base and fit the needs of the team who created it.
Maybe forking the project is our only option, but this is not an immediate need. Do you foresee the idea of independent registries being implemented in Quill 2.0 with a different design pattern? Also, are there specific areas of the design that you find problematic?
From what I can tell, it looks like the syntax module and some concerns about the boundingRectangle of the editor are the only incomplete details of the design. Otherwise it seems to function as intended. Again, this is a complex project, that I was not involved in from the start, so the nuances are beyond my ability and collaboration with the founders is entirely necessary to introduce updates to the API.
from parchment.
Supporting multiple editors better is a high priority so there is no disagreement on the need. I do intend for it to be a part of 2.0 one way or another.
The questions I posed in the issue were not very in depth (ex. what do the quickstart instructions look like now) and half were answered by just my drawing attention to them. The first premature jump into implementation already yielded the expected result of premature implementations. This is why I stress thinking through your solution first. This is not a Quill specific thing. We have not gotten to the interesting Quill parts yet and there is a ways before that happens, which I do not need nor have the time to be a part of.
from parchment.
Related Issues (20)
- Paste options for plain text content
- Inline Embed not working in 2.0 branch
- Is this condition of `uiNode` a typo? HOT 2
- registering a new blot does not add it to the allowed children of the scroll object
- block
- How cloud I understand Scope and What is the meaning of & operator between Scope and another Scope
- How to set editor content with html style
- Make v2 the default branch HOT 1
- register Blot unsucessfully
- [Question] Is it possible to define how a blot is serialized ? HOT 1
- How to add custom inline blot (or any blot whatsoever)? HOT 2
- Where can I find the old version commit? HOT 1
- Incorrect descendant typing (ts2769) HOT 1
- Adding a custom Blot HOT 1
- Remove Byte Order Mark (BOM) characters from Blot HOT 3
- Quill editor removes inline style margin-left on loading content
- the img tag is not closed HOT 1
- re-export classes from quill-delta and parchment
- How do we replicate the functionality inside a blot's `replace` function?
- Support ClassAttributor if prefix == ''
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from parchment.