Giter VIP home page Giter VIP logo

Comments (11)

charrondev avatar charrondev commented on August 22, 2024 8

I'm happy to ignore the code comments and keep them for my own personal knowledge of the project. I've created my first of a series of blog posts on parchment and posted it here:

https://dev.to/charrondev/getting-to-know-quilljs---part-1-parchment-blots-and-lifecycle--3e76

I'd appreciate any feedback you have.

from parchment.

charrondev avatar charrondev commented on August 22, 2024 3

I can't claim this is all accurate, but I've got my own fork here JSDoc comments on most of the code. I'm probably going to trim some of them down, now that I have a bit better of an understanding, and make a PR but you can take a look here: https://github.com/vanilla/parchment

from parchment.

jhchen avatar jhchen commented on August 22, 2024 3

As I mentioned in #46 I think it is most helpful if you start with a guide or blog post. If there are elements that I feel is helpful to Quill/Parchment we will go from there. Code comments are highly subjective and I will not debate the topic in Github.

from parchment.

charrondev avatar charrondev commented on August 22, 2024 2

I'm thinking it would be a bit of an easier read of it could be broken up into sections and cross-linked (and not need the long introductory "What is Quill and why am I writing this article" part at the top.)

from parchment.

coxandrew avatar coxandrew commented on August 22, 2024 2

Just wanted to say that this effort is much appreciated, @charrondev! Just reading through your branch with the function comments helped me through the custom blot I'm working on for my project.

from parchment.

charrondev avatar charrondev commented on August 22, 2024 2

There's actually 3 "embed" blots:

  • Parchment's EmbedBlot
    • Don't use this one.
  • Quill's Embed
  • Quill's BlockEmbed
    • This is for embeds that are like a line of their own.
    • On top of the base parchment blot it supports attributors and descendant children, and has some special handling in quill.
    • Here's an example of our error blot.

from parchment.

derekaug avatar derekaug commented on August 22, 2024

This would be super helpful for me, as I'm just getting started and some of these more advanced things are not touched at all in the documentation and the code itself is mostly void of documentation.

from parchment.

jacwright avatar jacwright commented on August 22, 2024

@jhchen are you interested in putting parchment docs into the quilljs repo, or this one? I think there is much value to this and would like to know what you would like to see happen.

from parchment.

charrondev avatar charrondev commented on August 22, 2024

I have feeling the Quill repo might be the right place. Most of the core blots are extended in a significant way from Quill. I would likely not find myself building on Parchment's Embed directly. I'd much rather build off of Quill's BlockEmbed or Embed.

from parchment.

andrei-cacio avatar andrei-cacio commented on August 22, 2024

@charrondev what's the difference betwee Quill's Emebed and Parchmnet's Embed?

from parchment.

quill-bot avatar quill-bot commented on August 22, 2024

Closing inactive issue.

from parchment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.