Comments (4)
tmsrjs
commented on June 30, 2024
It seems that SlackRubyBot::Client#owner is used inside the sample_app to log team info (team_id, name and domain), but this info is already present in SlackRubyBot::Client#team.
I think we can safely remove the monkey patch and modify the sample_app to pull this info from SlackRubyBot::Client#team.
What do you think?
from slack-ruby-bot-server.
dblock
commented on June 30, 2024
Possibly, but in most projects you need the actual stored team record with the token (the owner), not info about it after the client boots (which is what is stored as team), or some way to retrieve it, especially on restart. Check out how it's used in say https://github.com/dblock/slack-market.
from slack-ruby-bot-server.
tmsrjs
commented on June 30, 2024
Maybe I'm missing something, but couldn't we just Team.find_by(team_id: client.team.id) lazily when needed? The only scenario I think this could be a problem is if the same mongodb is used to store info for more than one slack-ruby-bot-server and more than one of those bots is added to the same team, but that sounds like bad design anyway.
from slack-ruby-bot-server.
dblock
commented on June 30, 2024
Isn't there a chicken-and-egg problem of knowing client.team.id? I am probably wrong, so as long as we can make it work, amen :)
from slack-ruby-bot-server.
Related Issues (20)
- How to integrate this lib with a Rails app? HOT 6
- Extract slack-ruby-bot-server-realtime HOT 1
- gem 'cursor_pagination' is conflicting with rails model generator HOT 2
- https://slack-ruby-bot-server.herokuapp.com no longer has a mongodb HOT 2
- oauth_authorization_url_mismatch for new slack apps HOT 5
- Migration guide for legacy Slack apps to Granular Scopes
- Unable to use Postgres HOT 5
- NameError: uninitialized constant SlackRubyBotServer::Api::Presenters::TeamPresenter::Boolean w/mongoid 7.3.x HOT 5
- Throws a Runtime Error if team is already regstered. HOT 6
- Add support for socket mode HOT 4
- Replace cursor_pagination HOT 12
- Add to Slack button - Redirect Endpoint? HOT 1
- What about this gem sets it up to show the Add To Slack button? HOT 3
- Document adding a RESTful API HOT 5
- Bot doesn't handle being removed from the last Organization on Slack side HOT 2
- Is there anyway to extend the Team model to add my own attributes? HOT 11
- Prevent test workflows from running when updating docs only HOT 1
- Release 2.1.0 HOT 1
- Disabling/Hiding some teams endpoints. HOT 4
- Configuring Log Level HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slack-ruby-bot-server.