Comments (1)
Great suggestion, and we would happily take you up on the offer to send a PR for this 🙇 ❤️
Taking a brief look, here is how I would approach an implementation, but this is only a suggestion:
- Copy the
HTTPReceiver
's approach of tracking asignatureVerification
boolean in the class, which can be set using the constructor. - The
AwsLambdaReceiver
'stoHandler
method outputs a function that is what will be invoked at runtime on the Lambda. Within this method there is a section that today executes signature verification every time. - Modify this section to check for the value of the newly-added
signatureVerification
boolean before executing any verification. - Add any tests covering the new functionality.
I think that would be sufficient! Happy to review any PRs or answer any other questions about this anyone may have.
from bolt-js.
Related Issues (20)
- Select menu of external data source - Max number - Problem HOT 5
- The 'value' property on ButtonAction is incorrectly typed HOT 3
- Typing support for built-in middleware handlers
- Japanese document updates reflecting #2136
- Bug: Adding block elements through code make actions disable HOT 12
- How to handle errors with invalid signing secret? HOT 5
- link_shared does not seem to be automatically calling ack() HOT 11
- Event triggered by unknown workspace HOT 2
- Change dependencies -> peerDependencies HOT 2
- Getting We had some trouble connecting. Try again? after updating a view. Using aws lambda. HOT 5
- app.client.chat.postMessage not triggering message event HOT 2
- Cannot push modal view using `trigger_id` HOT 5
- Add invalidRequestSignatureHandler to HTTP/ExpressReceiver
- Intermittent UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'type' of undefined HOT 2
- How do you develop at 2 at the same time with Slack? HOT 2
- Incorrectly formatted threaded broadcast reply message will raise `thread_broadcast` event HOT 6
- `PinnedMessageItem` interface missing `ts` HOT 1
- Multiple fields missing in `ChannelCreatedEvent` interface
- (Set a clear title describing the issue) HOT 2
- `client.chat.postMessage` with a user token throws `invalid_auth` error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bolt-js.