Comments (7)
Blah... gcov
has been so unreliable.
So, we had to add this check because sometimes gcov
just fails to create a coverage file for source file, even when you run the correct command on it. It seems to happen a lot with NSManagedObject
, for some reason.
Also, gcov
sometimes creates coverage files for other classes being used, so slather goes through and deletes them later.
I can't actually remember why I thought it was necessary to clean up after myself by deleting these files. It might not actually be necessary. Another solution, if it is necessary to delete them, could be to check if the file exists before deleting it. Would you mind modifying the gem locally and trying these out for me?
from slather.
I changed that line to:
gcov_files_created.each { |file| FileUtils.rm_f(file) }
Which seems to be equivalent to rm -f
so it ignores the file if it doesn't exist. After doing this I get a new crash.
Slathering...
/Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/project.rb:57:in `each': comparison of Float with Float failed (ArgumentError)
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/project.rb:57:in `max_by'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/project.rb:57:in `block in dedupe'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/project.rb:57:in `map'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/project.rb:57:in `dedupe'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/project.rb:51:in `coverage_files'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/lib/slather/coverage_service/simple_output.rb:13:in `post'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/bin/slather:57:in `post'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/bin/slather:33:in `execute'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/clamp-0.6.3/lib/clamp/command.rb:67:in `run'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/clamp-0.6.3/lib/clamp/subcommand/execution.rb:11:in `execute'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/clamp-0.6.3/lib/clamp/command.rb:67:in `run'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/clamp-0.6.3/lib/clamp/command.rb:125:in `run'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/clamp-0.6.3/lib/clamp.rb:6:in `Clamp'
from /Users/ksmiley/.rbenv/versions/2.1.3/lib/ruby/gems/2.1.0/gems/slather-1.3.0/bin/slather:6:in `<top (required)>'
from /Users/ksmiley/.rbenv/versions/2.1.3/bin/slather:23:in `load'
from /Users/ksmiley/.rbenv/versions/2.1.3/bin/slather:23:in `<main>'
from /Users/ksmiley/.rbenv/versions/2.1.3/bin/ruby_executable_hooks:15:in `eval'
from /Users/ksmiley/.rbenv/versions/2.1.3/bin/ruby_executable_hooks:15:in `<main>'
from slather.
Can you try this branch? #27
from slather.
That seems to work!
from slather.
Sweet! Gonna merge and cut a new release with @kylef's new cocoapod integration stuff.
from slather.
1.4.0
released to RubyGems
from slather.
Thanks!
from slather.
Related Issues (20)
- Unexpected token at ''
- Unit Test report doesn't included for XCODE 13 HOT 2
- Slather selects doccarchive when looking for binary
- Cobertura report shows wrong numbers
- Getting error `find_binary_files': No product binary found in Tests/Build/ProfileData/XXXXX-XXXXX while running on Azure Pipelines HOT 1
- M1 issue HOT 4
- Does ignore OR source directory work for anyone? HOT 1
- would it be possible to make a new release? HOT 2
- The guide for adding code coverage for iOS Swift and upload to Codecov
- Report reads little to no coverage HOT 2
- Ruby 3.2.0 issue
- Duplicates
- build-for-testing and CI/CD HOT 2
- Coveralls fail on coverage drop threshold hit on Github
- Slather not support XCUITest.
- slather dont generate all the coverage HOT 2
- [Feature request] Host Logo(image), CSS and JS in a CDN (or just here on github) HOT 1
- Update Nokogiri to version >= 1.14.3
- Coverage.profdata not found - Xcode 14.3 - Xcode 15.0 HOT 12
- Slather empty result on Jenkins CI HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slather.