Comments (13)
So after some discussion with the elasticsearch/elasticsearch
author, he was willing to add a new library to the class to help out our cause of keeping support for 5.x
. Take a look:
elastic/elasticsearch-php#534 (comment)
from plastic.
@sleimanx2 What needs doing on this? Is the work on the develop branch current, or is it out of date? I note that it is currently 32 commits behind master.
from plastic.
@sleimanx2 Any updates on this? We'd like to use it on our Laravel 5.4, ES 5.4 and PHP 7 site.
from plastic.
Please check v0.5.0 🥂
from plastic.
perfect added a develop branch for ES 5 support
from plastic.
I think this needs to be reopened and discussed a little more.
Right now you're wanting to include support for Laravel 5.2.*|5.3.*
. Well, 5.4.*
is now a thing.
Also, the underlying library of elasticsearch/elasticsearch
is going to require PHP ^7.0
as they require ext-json >= 1.3.7
. PHP 5.6.x
ships with ext-json 1.2.1
.
So if we want to support the elasticsearch/elasticsearch 5.x
the minimum PHP version Plastic will need to support is 7.0
. This cuts out all current Laravel versions as the framework only requires 5.6.4+
.
Laravel 5.5 will require PHP 7.0+
. So until Laravel requires 7.0 I would halt development and support on ES 5.
Once Laravel 5.5 is released we can change the composer.json
to the following:
"require": {
"php": ">=7.0",
"elasticsearch/elasticsearch": "~5.1",
"ongr/elasticsearch-dsl": "~5.0"
"illuminate/container": "5.5.*",
"illuminate/contracts": "5.5.*",
"illuminate/console": "5.5.*",
"illuminate/pagination": "5.5.*",
"illuminate/support": "5.5.*",
"illuminate/database": "5.5.*",
},
from plastic.
@ellisio I understand where you come from but what solution can we arrive at for people running PHP7 and wanting ES 5? Should we have a new major version of this library for these latest versions?
from plastic.
@ellisio how should we use this now?
from plastic.
@sleimanx2 @ellisio The ES library has been updated to 5.1.3 to support this - what are the next steps?
from plastic.
@ellisio @sleimanx2 any further update on how to get this to be compatible with ES 5.X?? I'm currently working on a large project involving laravel 5.4 with PHP 7.0.2 (Which is required for some of the processing within laravel) and would like to require this package with the latest ES.
from plastic.
@ellisio @sleimanx2 I'm also very interested having this package compatible with ES 5.X and PHP 7. Could we create a separate branch for that until Laravel 5.5 in July?
from plastic.
the issue is that the test are not green anymore due to the following update
Since Elasticsearch 5.0 the support for top level filters was dropped. The same functionality is now supported via BoolQuery
I'll work on fixing the issue soon.
from plastic.
Hey @sleimanx2 is there anything the community can do to help move this?
from plastic.
Related Issues (20)
- Nested query fails. Issue with Mapping?
- How to sync a property of a many-to-many relation (using a pivot table)?
- "Nothing to map" message but mappings exist HOT 1
- Can't populate the index with correct data HOT 1
- Update set id to 0 in elasticsearch HOT 1
- Populate and run mappings from json
- There is no good way to set custom model fillers
- Search on Translatable model HOT 1
- Compatibility and status of project HOT 3
- Feature request: Set search parameters for a query HOT 1
- return api response
- phrase_match with Plastic HOT 1
- plastic:populate does not include deleted records
- Consider this package unmaintained HOT 5
- Default $current for paginator in v0.3.1
- IAM - Signed Requests using Plastic
- Make plastic compatible with Laravel 5.7 HOT 5
- Is this project abandoned? HOT 1
- [ErrorException] filter_var(): explicit use of FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED is deprecated HOT 3
- How do I know actual search lucene query while using this library?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plastic.