Comments (9)
We should figure out what we want to do about certificates here.
Original comment by [email protected]
on 3 Oct 2006 at 6:52
from google-breakpad.
This patch is better ;-)
What do you mean about certificates? I admit I don't know much about the Windows
networking layer; are we worried that it would submit data even if the
certificate
were invalid?
Original comment by [email protected]
on 3 Oct 2006 at 7:38
Attachments:
from google-breakpad.
Yes, exactly: certificate validation.
Original comment by [email protected]
on 3 Oct 2006 at 8:46
from google-breakpad.
Original comment by [email protected]
on 16 Oct 2006 at 10:20
- Added labels: Milestone-Release1.0
from google-breakpad.
Original comment by [email protected]
on 18 Oct 2006 at 1:44
- Added labels: Component-Client-Sender, OpSys-Windows
from google-breakpad.
All we need to do is pass INTERNET_FLAG_SECURE in the flags argument of
HttpOpenRequest when the scheme is https.
For certificate verification, wininet will at least verify that the server
certificate's CN matches the hostname and that the date range is valid (bypass
with
INTERNET_FLAG_IGNORE_CERT_CN_INVALID and
INTERNET_FLAG_IGNORE_CERT_DATE_INVALID).
I'm not sure if it validates the certificate's trustworthiness or if that's
something
else we'd need to do ourselves.
Original comment by [email protected]
on 18 Oct 2006 at 9:33
from google-breakpad.
I've verified that comment 6 contains all that we need to do. If we follow
those
guidelines and attempt to hit a server with SSL/TLS, and it doesn't have a
trusted
certificate, HttpSendRequest will fail and GetLastError() will return
ERROR_INTERNET_INVALID_CA.
Original comment by [email protected]
on 19 Oct 2006 at 8:00
from google-breakpad.
This allows HTTPUpload users to specify an https scheme in the URL. It also
fixes
the proxy thing (#46) and checks the HTTP status returned by the server (which
sort
of fixes part of #44). I've also made the file version optional, although a
warning
is printed when the version is missing, and the server's free to reject
versionless
uploads.
Original comment by [email protected]
on 19 Oct 2006 at 8:24
- Changed state: Accepted
Attachments:
from google-breakpad.
Checked in, revision [41] (for #41!)
Original comment by [email protected]
on 19 Oct 2006 at 9:49
- Changed state: Fixed
from google-breakpad.
Related Issues (20)
- Test coverage for readtaskmemory HOT 3
- Linux: Crash when generating large .sym files with dump_syms HOT 3
- <no title> HOT 1
- 64-bit code path needs to check for LC_SEGMENT_64 when iterating through binary HOT 2
- ReadImageInfoForTask needs test coverage HOT 3
- mach_vm_region_recurse calls have invalid parameter specified on Tiger HOT 2
- GetWindowTextLength or SendMessage is not thread-safe? HOT 1
- Crash Report should parse Apple crashreporter dumps and match them to Breakpad symbols HOT 2
- Mac OS X image listing code needs to handle duplicate load addresses HOT 2
- symupload tool on mac doesn't handle spaces in module name correctly HOT 1
- Compilation under OpenSuSE Linux 11.0 HOT 2
- linked_ptr segfaults oin some cases HOT 9
- Licensing issues with src/common/convert_UTF.c HOT 10
- memcpy not included HOT 3
- error: 'transform' is not a member of 'std' HOT 2
- Deadlock when triggering a crash in crash_greneration_app HOT 3
- Generate a libexception_handler for Linux HOT 4
- patch to include list of loaded modules in crash_report output HOT 2
- generate GUIDs ahead of time in Linux handler HOT 1
- Make processor build and run on win32 with visual studio 2005 or 2008
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-breakpad.