macOS dashboard build is broken about sliceropencv HOT 13 CLOSED

the PR above did not fix the problem: http://slicer.cdash.org/viewBuildError.php?buildid=1190489

from sliceropencv.

I would wait for a clean build. I do not have an older Mac to test on, but I'm pretty sure this should fix the problem.

from sliceropencv.

Adam, what do you mean by "a clean build"?

from sliceropencv.

Well, I've noticed that the build machines don't always reflect the state of a build after a change. I think there's perhaps some build optimization that happens that results in a clean build not occurring.

Ideally, I'd like to test a clean build, from scratch on a version of OSX that has this issue.

from sliceropencv.

the build machines don't always reflect the state of a build after a change

As suggested by @jcfr in #43, there should not be any lingering issues with the dashboard after update.

I do not have a version of OSX that has this issue.

from sliceropencv.

I think there's perhaps some build optimization that happens that results in a clean build not occurring.

Nightly build are done clean every day for both Slicer and extension build.

For build associated with the latest release (4.8), the existing Slicer build tree is reused everyday, but the corresponding extension builds are done clean.

I do not have an older Mac to test on, but I'm pretty sure this should fix the problem.

Starting tonight, macOS build should be done on a newer mac with Qt5 and VTK9.

That said, I just checked the SlicerOpenCV extension and OpenCV build system and setting BUILD_PROTOBUF will not have the effect you expect.

Instead, to avoid building with protobuf you should set BUILD_opencv_dnn:BOOL=OFF.

This means, to address that specific issue (the protobuf build failure), I suggest you revert f1b08a2 and set BUILD_opencv_dnn:BOOL=OFF for all platform. dnn is the module requiring protobuf.

Good news: I just checked and that allow the build to move forward on macOS 10.6 (factory-macos)

Bar news: But now there is an other one:

In file included from /Users/kitware/Dashboards/Nightly/S-0-E-b/SlicerOpenCV-build/OpenCV-build/modules/core/mathfuncs_core.avx2.cpp:3:
/Users/kitware/Dashboards/Nightly/S-0-E-b/SlicerOpenCV-build/OpenCV-source/modules/core/src/mathfuncs_core.simd.hpp:560:18: error: use of undeclared identifier '_mm256_fmadd_ps'; did you mean '_mm256_blendv_ps'?
            zf = _mm256_fmadd_ps(zf, xf, mA2);
                 ^~~~~~~~~~~~~~~
                 _mm256_blendv_ps

To move forward:

• Extension built for Slicer 4.8 should not update OpenCV.

• Extension built for Slicer master should work as expected as a newer compiler is used.

Hth
Jc

from sliceropencv.

Ok, good to know, I thought turning off protobuf disabled dnn.

Should we change the 4.8 extension index to point to a specific revision?

from sliceropencv.

Great investigative work, thank you JC!

I will set 4.8 to point to the revision before the upgrade of OpenCV.

Adam, is it helpful for you to have the updated OpenCV version in the nightly? If yes, then let's keep it red, and wait for the new compiler. If it doesn't matter for you, I suggest we revert the commit upgrading the version until the compilers are updated.

from sliceropencv.

from sliceropencv.

It is fine with me, let's keep it - I think at this point you might be the primary user of SlicerOpenCV other than SlicerPathology. I don't know of anyone else using it, and no one complained when dashboard broke.

from sliceropencv.

Great investigative work, thank you JC!

No problem. Glad progress was made.

I will set 4.8 to point to the revision before the upgrade of OpenCV.
Should we change the 4.8 extension index to point to a specific revision?

I suggest you create a branch named master-48 based of the revision known to work with the corresponding version of Slicer

from sliceropencv.

@jcfr done!

from sliceropencv.

The macOS build is working today!

from sliceropencv.