Comments (13)
the PR above did not fix the problem: http://slicer.cdash.org/viewBuildError.php?buildid=1190489
from sliceropencv.
I would wait for a clean build. I do not have an older Mac to test on, but I'm pretty sure this should fix the problem.
from sliceropencv.
Adam, what do you mean by "a clean build"?
from sliceropencv.
Well, I've noticed that the build machines don't always reflect the state of a build after a change. I think there's perhaps some build optimization that happens that results in a clean build not occurring.
Ideally, I'd like to test a clean build, from scratch on a version of OSX that has this issue.
from sliceropencv.
the build machines don't always reflect the state of a build after a change
As suggested by @jcfr in #43, there should not be any lingering issues with the dashboard after update.
I do not have a version of OSX that has this issue.
from sliceropencv.
I think there's perhaps some build optimization that happens that results in a clean build not occurring.
Nightly build are done clean every day for both Slicer and extension build.
For build associated with the latest release (4.8), the existing Slicer build tree is reused everyday, but the corresponding extension builds are done clean.
I do not have an older Mac to test on, but I'm pretty sure this should fix the problem.
Starting tonight, macOS build should be done on a newer mac with Qt5 and VTK9.
That said, I just checked the SlicerOpenCV extension and OpenCV build system and setting BUILD_PROTOBUF
will not have the effect you expect.
Instead, to avoid building with protobuf you should set BUILD_opencv_dnn:BOOL=OFF
.
This means, to address that specific issue (the protobuf build failure), I suggest you revert f1b08a2 and set BUILD_opencv_dnn:BOOL=OFF
for all platform. dnn
is the module requiring protobuf.
Good news: I just checked and that allow the build to move forward on macOS 10.6 (factory-macos)
Bar news: But now there is an other one:
In file included from /Users/kitware/Dashboards/Nightly/S-0-E-b/SlicerOpenCV-build/OpenCV-build/modules/core/mathfuncs_core.avx2.cpp:3:
/Users/kitware/Dashboards/Nightly/S-0-E-b/SlicerOpenCV-build/OpenCV-source/modules/core/src/mathfuncs_core.simd.hpp:560:18: error: use of undeclared identifier '_mm256_fmadd_ps'; did you mean '_mm256_blendv_ps'?
zf = _mm256_fmadd_ps(zf, xf, mA2);
^~~~~~~~~~~~~~~
_mm256_blendv_ps
To move forward:
-
Extension built for Slicer 4.8 should not update OpenCV.
-
Extension built for Slicer master should work as expected as a newer compiler is used.
Hth
Jc
from sliceropencv.
Ok, good to know, I thought turning off protobuf disabled dnn.
Should we change the 4.8 extension index to point to a specific revision?
from sliceropencv.
Great investigative work, thank you JC!
I will set 4.8 to point to the revision before the upgrade of OpenCV.
Adam, is it helpful for you to have the updated OpenCV version in the nightly? If yes, then let's keep it red, and wait for the new compiler. If it doesn't matter for you, I suggest we revert the commit upgrading the version until the compilers are updated.
from sliceropencv.
from sliceropencv.
It is fine with me, let's keep it - I think at this point you might be the primary user of SlicerOpenCV other than SlicerPathology. I don't know of anyone else using it, and no one complained when dashboard broke.
from sliceropencv.
Great investigative work, thank you JC!
No problem. Glad progress was made.
I will set 4.8 to point to the revision before the upgrade of OpenCV.
Should we change the 4.8 extension index to point to a specific revision?
I suggest you create a branch named master-48
based of the revision known to work with the corresponding version of Slicer
from sliceropencv.
@jcfr done!
from sliceropencv.
The macOS build is working today!
from sliceropencv.
Related Issues (20)
- Linking error on Mac HOT 5
- Windows: Fix error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in itkOpenCVVideoIO.obj HOT 3
- Improve SlicerOpenCVConfig to ensure dependent project find the expected OpenCV libraries
- `is not a valid Qt plugin` error on startup HOT 37
- Remove debug print statements HOT 6
- CLI failed on reading the input image from the shared memory pointer HOT 2
- fatal error: Eigen/Eigenvalues: No such file or directory when trying to build latest SlicerOpenCV on Ubuntu HOT 8
- Fix Windows build/test errors HOT 13
- Extension not available on either Linux or Mac dashboards HOT 4
- Hard-coded MD5 HOT 2
- Example of vtkImageData to cv2.Mat in Python HOT 2
- import cv2 fails in nightly HOT 8
- OpenCV is no longer python wrapped in latest nightly HOT 1
- Nightly extension failing to build on Windows and macOS HOT 1
- Extension fails to build HOT 3
- Adding zlib as dependency to OpenCV project lead to build errors
- OpenCV_contrib module `wechat_qrcode` leads to build error in client project
- Python bindings not generated HOT 6
- Build error on linux and macOS HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sliceropencv.