Comments (9)
I just confirmed that turning off the wi-fi produces a timeout error in the status bar.
from refact-sublime.
produces a timeout error in the status bar
Cool, but we need error to go via LSP, not through stderr. We want a good product, written correctly, no hacks.
from refact-sublime.
The error is generated from the rpc connection. The rpc connection uses stdio in favour of an http connection because the server is running locally.
from refact-sublime.
The main reason the code monitors the process through stderr is to address the issue where the server would crash but the process would not terminate. By monitoring for crashes directly the code is able to cleanly close the server.
from refact-sublime.
refact-lsp
does not crash. I think we fixed all or nearly all error handling in rust, so unlikely it will panic or exit.
from refact-sublime.
This code is over a month old. If the refact server doesn't crash anymore then this code can be removed.
from refact-sublime.
![image](https://private-user-images.githubusercontent.com/18546213/307619565-9983c18f-a566-4f44-9d28-aebb52a627f8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUyMjEzOTIsIm5iZiI6MTcyNTIyMTA5MiwicGF0aCI6Ii8xODU0NjIxMy8zMDc2MTk1NjUtOTk4M2MxOGYtYTU2Ni00ZjQ0LTlkMjgtYWViYjUyYTYyN2Y4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAxVDIwMDQ1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiOGIyNmZhZmQyOGI0M2I3YmNlYjAxYWU4MDE5MjRmOTNjOGM0YzlkYzIzZjc3M2Y0NDM3OWU1OGM2NGEzYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.TX28BBMRHRGD3ewK0HkSahM1INudvBK8LOwYGQFlWKs)
I just exited Sublime Text, two processes left over.
from refact-sublime.
Tested: process does not restart
The process does not restart with relevant settings change, specifically api_key, address_url, telemetry_code_snippets.
^^ this specifically doesn't work.
![image](https://private-user-images.githubusercontent.com/18546213/309563785-f8339424-f324-4c34-8ce0-147efb071bf0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUyMjEzOTIsIm5iZiI6MTcyNTIyMTA5MiwicGF0aCI6Ii8xODU0NjIxMy8zMDk1NjM3ODUtZjgzMzk0MjQtZjMyNC00YzM0LThjZTAtMTQ3ZWZiMDcxYmYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTAxVDIwMDQ1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2MzViZDg0ZDBiZjcyZjViNTkwMDVhNDU3ZmZlZThmZDJlNTAxYTk5YTNkZTI2MmQxMDUxYTVmMWE0OTgwNmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vUKDE4yyGKCff-pyoRzNejIaqWsluYFivWZar-i8jUY)
Here if I change "zzz" to "www" it doesn't restart the refact-lsp
process with the new command line.
from refact-sublime.
Checked #16 - changing option in plugin settings restarts the refact-lsp.
from refact-sublime.
Related Issues (12)
- Version v0.1 HOT 21
- Need LSP workspace folders and events HOT 13
- Fix closing brackets HOT 3
- Version v0.2 HOT 19
- Completion doesn't start after "pause refact" HOT 4
- Sometimes grey text doesn't appear HOT 5
- [WIN] When running Sublime, when refact-lsp starts, PowerShell window opens with refact-lsp process HOT 2
- [WIN] When creating a new unsaved file, autocompletion does not work in it HOT 2
- Make settings accessible via menu HOT 2
- Status bar is flickering HOT 1
- Any plans to make this available at https://packagecontrol.io/?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refact-sublime.