refact-lsp process handling about refact-sublime HOT 9 CLOSED

I just confirmed that turning off the wi-fi produces a timeout error in the status bar.

from refact-sublime.

produces a timeout error in the status bar

Cool, but we need error to go via LSP, not through stderr. We want a good product, written correctly, no hacks.

from refact-sublime.

The error is generated from the rpc connection. The rpc connection uses stdio in favour of an http connection because the server is running locally.

from refact-sublime.

The main reason the code monitors the process through stderr is to address the issue where the server would crash but the process would not terminate. By monitoring for crashes directly the code is able to cleanly close the server.

from refact-sublime.

refact-lsp does not crash. I think we fixed all or nearly all error handling in rust, so unlikely it will panic or exit.

from refact-sublime.

This code is over a month old. If the refact server doesn't crash anymore then this code can be removed.

from refact-sublime.

I just exited Sublime Text, two processes left over.

from refact-sublime.

Tested: process does not restart

The process does not restart with relevant settings change, specifically api_key, address_url, telemetry_code_snippets.

^^ this specifically doesn't work.

Here if I change "zzz" to "www" it doesn't restart the refact-lsp process with the new command line.

from refact-sublime.

Checked #16 - changing option in plugin settings restarts the refact-lsp.

from refact-sublime.