In the app-shell example debugging mode, saving package.json will prompt that the port is used about piral HOT 6 CLOSED

Thanks for the report. A fix for this is out with the latest preview (next).

from piral.

I tested and it was fixed, thank you!

from piral.

We restart the process independent of what the bundler does. So in case of Webpack it might be sensitive to the package.json, however, this is nothing we control or will change.

If this edge case really impacts you (how?) then configure webpack to ignore the package.json. I think this is rather a cosmetic issue and for reliability it makes more sense that we restart the process than having just a single build here.

from piral.

Actually it is very reasonable. Thanks for spotting - with my answer I thought we already spot it and what you see is the triggering beforehand, but actually the bundler process keeps on running.

Perfect PR - wonderful!

from piral.

There are the same problem with using pilet debug command in a monorepo. See the mwe

Environment Details and Version
[email protected]

Expected behavior
webpack always builds only once

Actual behavior
webpack performs multiple builds

1. yarn && yarn build && cd src/samples/sample-pilet && yarn start
2. Press the command + s shortcut key to save the src/samples/sample-pilet/package.json file
3. Press the command + s shortcut key to save the src/samples/sample-pilet/src/index.tsx file

from piral.

We restart the process independent of what the bundler does. So in case of Webpack it might be sensitive to the package.json, however, this is nothing we control or will change.

If this edge case really impacts you (how?) then configure webpack to ignore the package.json. I think this is rather a cosmetic issue and for reliability it makes more sense that we restart the process than having just a single build here.

I completely agree with your idea, but the repeated build may be related to not restarting webpack when restarting the pilet process. After testing, pr fixed this problem. But since I don’t fully understand the logic of piral-cli, I don’t know if pr is reasonable.

from piral.