Random number is always 0 about hardhat-starter-kit HOT 4 CLOSED

Hi @RafaelVidaurre , thanks for raising this. Looks to be a bug with the logic around the ==0 vs == -1. That if statement should only return true if you're not working on a local network (ie you're working on a public network that's integrated to a real Chainlink network).

If working on a local network, you can't really use the 'request-random-number' task, because there's no integration to a real Chainlink network. Take a look at the unit tests to see what can be done when working locally

Also, if you'd like to contribute to improving our hardhat starter kit, you can raise a PR on our starter kit to correct the bug, and we can then review it and have it merged to the main repository

from hardhat-starter-kit.

@pappas999 thanks for clarifying this, I understand now what my options are. I'll see if I can submit a PR to improve this part. So, more than the random number = 0 being a bug, it is a limitation when working locally. So I guess the only real issue here is the logic by which we output these messages to the console, and maybe that we should mention the differences between working locally vs working with a test net for development.

from hardhat-starter-kit.

Correct, looks like the issue is in the logic as to whether to print that statement to the console or not, because it's looking for when it's a local network, whereas it should be looking for when it's not a local network (and we have a 0 result)

from hardhat-starter-kit.

Closing this for now, but feel free to follow up.

from hardhat-starter-kit.