Giter VIP home page Giter VIP logo

Comments (4)

pappas999 avatar pappas999 commented on June 8, 2024 2

Hi @shivam-agarwal-0 , thanks for much for volunteering to take on this PR. To action it successfully, you should change the variable in the solidity contract to be a bytes32 instead of a string, and then in any of the hardhat tasks or scripts that interact with the contract, you should use ethers.js library function like the one you specified to convert the string into a bytes32 to pass into the contract

from hardhat-starter-kit.

pappas999 avatar pappas999 commented on June 8, 2024

thanks for raising, makes sense

from hardhat-starter-kit.

0xshivamagarwal avatar 0xshivamagarwal commented on June 8, 2024

Hey @pappas999 @PatrickAlphaC ,
According to my understanding, in APIConsumer.sol stringToBytes32 function call in constructor needs to be removed and formatBytes32 should be used in deploy javascript file.
If my understanding is correct can I work on this issue?

from hardhat-starter-kit.

0xshivamagarwal avatar 0xshivamagarwal commented on June 8, 2024

Hey @pappas999 , I have opened a PR for this issue: #62
Please review and let me know if anything needs to be changed

from hardhat-starter-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.