Comments (1)
Hi, thanks for using smartcore
and finding this.
It looks like at the moment cross_validate
works only for types that implement SupervisedEstimator
trait; SVC implement SupervisedEstimatorBorrow
instead, that is a variant that allows saving memory allocation. The solution can be:
- or we implement
SupervisedEstimator
for SVC in place ofSupervisedEstimatorBorrow
- or we change
cross_validate
to acceptSupervisedEstimatorBorrow
and implement it for the other models (linear regression, ...); this waySupervisedEstimator
will be used only withcross_val_predict
(because it actually need apredict
method). - or we develop a
cross_validate_borrow
function that takes types that implementSupervisedEstimatorBorrow
SVC was not meant to be used with cross_validate
in the first place as we didn't have a use case for that. At the moment cross_validate
works only with estimators that have also Predictor
trait (SupervisedEstimator
is composed with Predictor
while the "borrow" version is not). There is note about this in the documentation but I admit it should be referenced in the cross_validate
documentation.
If you have any idea about how to fix this it would be great to hear, you can also open a Pull Request to fix it. If it is indeed deemed useful and we find a solution it will be released with the next version.
NOTE: model_selection
module is missing the documentation, it would be also great if you can provide it.
from smartcore.
Related Issues (20)
- Improve Display for naive_bayes HOT 1
- Investigate possible usages of const contexts
- Use Default::default instead of new in traits HOT 2
- Improve and provide more tools for trees
- Consider implementing XGBoost HOT 2
- Run analysis for size and alignment of non-primitive types HOT 1
- Examples on website does not work with smartcore 0.3.0 HOT 3
- A roadmap to implement RL model-free algorithms
- Prediction of GaussianNB panics in some conditions HOT 2
- Survival analysis HOT 1
- Allow read/write of parquet files
- Implement LEURN
- index out of bounds error using logistic_regression HOT 12
- Have a guide for Wasm compilation HOT 2
- Performance HOT 1
- Cannot perform inference on deserialized SVC and SVR HOT 8
- how to read x/y from csv file? HOT 2
- smartcore::readers import causes error "could not find `readers` in `smartcore`"
- Panics in NaiveBayes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smartcore.