Comments (5)
Done :) 1.0.0 is now published, returning {:ok, %Cloudex.UploadedImage{}} for a single file / url and a list of those when uploading multiple.
from cloudex.
Hi,
I agree that this is an anomaly indeed. Ideally it should return a tuple if only one file is uploaded and a list of tuples when multiple where uploaded.
I'd like to change this behaviour but do not really know what the best way would be to make this change with the least amount of disruption for the current users.
One possibility would be to do a major version increase to make this change, with a clear note of the breaking change, and the usual annotation in the changelog. I'm also open for more suggestions on how to properly make this change. Pinging some contributors to see if they might have some input as well on this :) @nathanl @Tyler-pierce @pauloancheta @nbancajas @sudostack @remiq
Thanks in advance, Gerard
from cloudex.
I'd vote for "make the change and do a major version bump, explaining in the changelog." I see that Cloudex isn't at 1.0 yet, but I think it could be. Nothing is ever complete, but what it does, it does well.
from cloudex.
+1 major version change to notify existing users of the breaking interface. Curious, as I am the first to mention the discrepancy, are most users passing a list. Wonder what percentage of users are passing a single, non-list input to the method.
from cloudex.
+1 on major change and explain in the changelog. And as @billc have mentioned, there might not be a lot of users a non-list input to the method. Disruption to other users would be minimal.
from cloudex.
Related Issues (20)
- Adding support for retrieving a resource HOT 2
- upload return type is incorrect HOT 1
- Add 'moderation' to struct HOT 1
- Upload in clear
- Allow timer 3.2 HOT 1
- Update for latest timex 3.3.0 HOT 1
- Support for fetching remote images HOT 1
- Support for videos HOT 4
- Tests failing HOT 4
- Uploading video and audio files. HOT 1
- Signature includes `resource_type` HOT 1
- Using eager transformations in image upload. HOT 1
- Delete URL does not include `notification_url` HOT 1
- Make JSON lib configurable HOT 3
- Cloudex.delete/1 does not seem to delete asset HOT 2
- Add guidance in README on how I might be able to use this in my own context tests. Can I set up a local, sandboxed version of Cloudex?
- First process supervisor
- Timeouts on upload can't be configured HOT 1
- Cloud name not drawing from config HOT 1
- Compilation error when using phoenix helper
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudex.