Comments (5)
Thank you for bringing the case insensitivity to the light. I've updated it to be case insensitive now.
Checking the file extension was more to make sure we are uploading something useful to Cloudinary, this should be replaced with a mime type check to make it less fickle and to remove the dependency of an extension. @manukall maybe you have some input as well about this ?
from cloudex.
to be honest i'm directly using the functions in Cloudex.CloudinaryApi.Live
, mainly because of this check. imho it could completely go and maybe be offered as an opt-in helper function, like image_list |> Cloudex.filter_image_urls |> Cloudex.upload
.
from cloudex.
I'm also of the opinion that the check should be an optional helper. Feels like Phoenix uploads are a common case. The submitted filename
is available in the Plug.Upload
struct and that is would be the easier thing to check against rather than path
.
Alternatively Cloudex.upload
could provide an option to skip the check.
from cloudex.
I've updated the hex and removed both the file and url extension checks.
Thank you all for your input on this 👍
from cloudex.
Thanks @smeevil!
from cloudex.
Related Issues (20)
- Adding support for retrieving a resource HOT 2
- upload return type is incorrect HOT 1
- Add 'moderation' to struct HOT 1
- Upload in clear
- Allow timer 3.2 HOT 1
- Update for latest timex 3.3.0 HOT 1
- Support for fetching remote images HOT 1
- Support for videos HOT 4
- Tests failing HOT 4
- Uploading video and audio files. HOT 1
- Signature includes `resource_type` HOT 1
- Using eager transformations in image upload. HOT 1
- Delete URL does not include `notification_url` HOT 1
- Make JSON lib configurable HOT 3
- Cloudex.delete/1 does not seem to delete asset HOT 2
- Add guidance in README on how I might be able to use this in my own context tests. Can I set up a local, sandboxed version of Cloudex?
- First process supervisor
- Timeouts on upload can't be configured HOT 1
- Cloud name not drawing from config HOT 1
- Compilation error when using phoenix helper
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudex.