Absent of possibility to get geoiprecord AND geoipdnsrecord about zfsnapgeoip HOT 7 CLOSED

I guess It should be re-factored to utilize Record class as entity. In any case I would prefer to see Doctrine ORM logic. That means to get geoip class, through it run 'find($ip)' or 'lookup($ip)' what will return some entity like custom Record (Their can be several types in geoip vendor). And through Entity(Record) gets all properties.

from zfsnapgeoip.

First issue fixed. Check latest changes.

To faster refactor from second comment (which is good idea) please make new issue.

from zfsnapgeoip.

Hi! Thanks.
But why did you this package stable (ver. 1.0) if I wanted base changes in it?
I would pull fork and remake it, if I knew that it alive.

Hence your no response I've created geoip-module with base classes what I really needed, but It needs test and README etc. So if you will work at it, I can merge them.

from zfsnapgeoip.

I'll create v2. Tomorrow I'll send code for review

from zfsnapgeoip.

@vnagara check it now! :)

from zfsnapgeoip.

Yeah! It looks much better. Is the Record class be entity? Can not It be a Document Object for ODM?
If I merged them It would be better. I spent about a day to look through mixmind features.

from zfsnapgeoip.

What's different between GeoipModule\Object\Record and ZfSnapGeoip\Entity\Record?

from zfsnapgeoip.