Giter VIP home page Giter VIP logo

Comments (8)

dawiddczaja avatar dawiddczaja commented on May 29, 2024

Hello, I tried reproduce bug in CE and EE version but without effect. Which magento and magento2-menu version you have ?

from magento2-menu.

SilvanLaroo avatar SilvanLaroo commented on May 29, 2024

Hi,

I'm facing the same issue. I'm using Magento 2.1.7 and the latest version of your extension.

from magento2-menu.

macdar avatar macdar commented on May 29, 2024

@bvboas @SilvanLaroo fixed on develop branch. Please test.

from magento2-menu.

SilvanLaroo avatar SilvanLaroo commented on May 29, 2024

I've just installed the version from dev-develop, but got a similar error:
Warning: Uncaught Exception: Warning: Declaration of Snowdog\Menu\Block\NodeType\Category\Interceptor::isCurrentCategory($nodeId) should be compatible with Snowdog\Menu\Block\NodeType\Category::isCurrentCategory(int $nodeId) in

from magento2-menu.

macdar avatar macdar commented on May 29, 2024

@SilvanLaroo thanks but that's not directly related to this issue. I will open a separate issue for that.
Anyway please confirm the error reported here has been fixed, ok?

from magento2-menu.

SilvanLaroo avatar SilvanLaroo commented on May 29, 2024

It's related right? The problem is that Magento does not include Scalar Type hinting in the var/generation files.

from magento2-menu.

macdar avatar macdar commented on May 29, 2024

That's right. Magento Team fixed it here magento/magento2#6106 but it hasn't been merged into the master branch yet.
I created a separate task to remove all PHP7 type hints in our module: #10

from magento2-menu.

macdar avatar macdar commented on May 29, 2024

The fix has been merged into the develop branch (bd50cd2).

from magento2-menu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.