Giter VIP home page Giter VIP logo

Comments (6)

faustbrian avatar faustbrian commented on August 19, 2024

No, only Laravel 5.4+.

from providers.

Arekusei avatar Arekusei commented on August 19, 2024

But the differences between commits insignificant.
SocialiteProviders/Steam@95cf629
This commit compatible with 2.0 manager.
New commits contain no significant changes except change itself composer.json.
It's like something out illogical.

from providers.

faustbrian avatar faustbrian commented on August 19, 2024

The version requirement is not about one single commit being compatible or not, there are differences between Socialite 2.0 and 3.0 which require different Manager releases.

All new providers will require Socialite 3.0 and Laravel 5.4 or higher to make sure the latest releases are supported. If you don't like to use the newest releases of Laravel and Co. that's fine but please don't just dismiss it as illogical.

from providers.

Arekusei avatar Arekusei commented on August 19, 2024

I mean that the incompatibility within the provider for Steam (as it should be, and many others) is not available, but it is encapsulated in the manager. Accordingly illogical formally compliant package/provider to do incompatible.

from providers.

Arekusei avatar Arekusei commented on August 19, 2024

Why not mark the package as is compatible with the two versions of the manager.

"socialiteproviders/manager": "~2.0 || ~3.0",

from providers.

faustbrian avatar faustbrian commented on August 19, 2024

Laravel 5.3 and 5.4 have different method names and I am not going to plunge a bunch of checks in some providers to check if the put or set method has to be called.

Everything onwards will require Laravel 5.4 and Socialite 3.0 or newer, that's the current state and will stay like this for now.

from providers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.