Giter VIP home page Giter VIP logo

Comments (4)

trinopoty avatar trinopoty commented on June 2, 2024

Maybe use an AtomicLong with a seed value from System.currentTimeMillis?

from engine.io-client-java.

darrachequesne avatar darrachequesne commented on June 2, 2024

Hi @trinopoty, sorry for the delay on this issue.

this is causing problems like two distinct connections getting the same id

If I'm not mistaken, the string created by yeast is used in the query params, to prevent a proxy from caching the response of the server. Are you suggesting it does happen when sending several HTTP requests in a row?

Note: in the JS server, the session ID (sid in the query param) is generated by the base64id module here

from engine.io-client-java.

trinopoty avatar trinopoty commented on June 2, 2024

Yeast is using new Date().getTime() to generate a session id. On the server library, this was causing issues where two unrelated connections got the same sid because they came in at around the same time. I switched it over to an AtomicLong based implementation.
From the looks of it, this will not be too much of a problem in this library since it does not generate sid.

from engine.io-client-java.

darrachequesne avatar darrachequesne commented on June 2, 2024

Oh ok, thanks for the explanation!

That being said, the yeast() method is indeed not thread safe, which might cause some problems when creating several java clients (during load tests, for example).

from engine.io-client-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.