Giter VIP home page Giter VIP logo

Comments (3)

ngot avatar ngot commented on June 14, 2024 1

According to redis/node-redis#2502 (comment), the sUnsubscribe(Array[]) assumes all the channels use "hash tags", so they are allocated to the same slot.

In socket.io-redis-adapter, there is dynamic channels, so sUnsubscribe one by one looks more doable.

Additionally, this is the usage of iosredis, it does not support array, but spread parameters.
https://github.com/luin/ioredis/blob/a3838ae7598c7d9d3aff688923403f6176d7a393/lib/utils/RedisCommander.ts#L8356

  /**
   * Stop listening for messages posted to the given shard channels
   * - _group_: pubsub
   * - _complexity_: O(N) where N is the number of clients already subscribed to a shard channel.
   * - _since_: 7.0.0
   */
  sunsubscribe(callback?: Callback<unknown>): Result<unknown, Context>;
  sunsubscribe(
    ...args: [
      ...shardchannels: (string | Buffer)[],
      callback: Callback<unknown>
    ]
  ): Result<unknown, Context>;
  sunsubscribe(
    ...args: [...shardchannels: (string | Buffer)[]]
  ): Result<unknown, Context>;

from socket.io-redis-adapter.

darrachequesne avatar darrachequesne commented on June 14, 2024

Hi! Thanks for raising the issue, I'm digging into this.

from socket.io-redis-adapter.

darrachequesne avatar darrachequesne commented on June 14, 2024

This should be fixed by 2da8d9e, included in version 8.2.1.

@ngot thanks for the analysis 👍

from socket.io-redis-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.