Giter VIP home page Giter VIP logo

Comments (8)

Segaja avatar Segaja commented on July 17, 2024

bump

from nio4r.

ioquatix avatar ioquatix commented on July 17, 2024

Do you mind making a PR? Thanks!

from nio4r.

voxik avatar voxik commented on July 17, 2024

e53e5d5 is the root cause for the issue. The question is if it should be reverted, or if the constant should be pre-defined outside of the block. But revert is probably easier solution.

from nio4r.

MSP-Greg avatar MSP-Greg commented on July 17, 2024

Boy, that was stupid (I authored the commit). Don't recall. I think the intent was to not load openssl when the spec files load, so some specs may run without openssl being loaded. Maybe change

RSpec.describe OpenSSL::SSL::SSLSocket do

to

RSpec.describe 'OpenSSL::SSL::SSLSocket' do

from nio4r.

Segaja avatar Segaja commented on July 17, 2024

Will this be patched in the code soon, @MSP-Greg ?

from nio4r.

MSP-Greg avatar MSP-Greg commented on July 17, 2024

@Segaja Not sure. If the above is used, other specs can be run without loading Ruby's OpenSSL. Not sure if that's helpful.

Happy to do a PR with the above...

from nio4r.

Segaja avatar Segaja commented on July 17, 2024

@MSP-Greg I can confirm the fix above with the quotes works. For now I patch it manually in the build for arch, but it would be nice if it would be fixed in the project itself.

from nio4r.

ioquatix avatar ioquatix commented on July 17, 2024

I've fixed this by moving the require to before the describe block.

from nio4r.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.