I'm getting an error when I run the examples on windows about socket-examples HOT 10 CLOSED

@lamiazar @wujekbizon please try the latest master. @mribbons fixes the issue in socketsupply/socket#420

it's working for me

@mribbons thank you!

from socket-examples.

Yes, we can close it

from socket-examples.

Run `npm audit` for details.
PS C:\Users\lamia\socket-examples\advanced\create-react-app> ssc build -r -o
• warning! $CXX env var not set, assuming defaults 29ms
• cleaned: C:\Users\lamia\socket-examples\advanced\create-react-app\dist\win 2ms
• preparing build for win 2ms
• using 'C:/Users/lamia/AppData/Roaming/npm/node_modules/@socketsupply/socket/node_modules/@socketsupply/socket-win32-x64\' as 'SOCKET_HOME' 0ms
• package prepared 59ms
• build failed, exiting with code -1 1716764ms

from socket-examples.

Hey @chicoxyzzy , I've got same error alert : Unable to execute PUBLIC_URL=./npm run build

from socket-examples.

Ah, that's a create-react-app example issue. I can fix it

from socket-examples.

@chicoxyzzy I opened this issue #69 and I think it's a duplicate.
Can I close #69 ?

from socket-examples.

I've merged #70 cause it still works on macOS and Linux and works for some people (only me at the moment) on Windows, so it at least doesn't break anything. We need to check it on more machines. According to CRA docs it should just work.

from socket-examples.

It doesn't work for me as you know with old/ new version of ssc, I tried on my vm and a win machine

from socket-examples.

@lamiazar @wujekbizon please try latest master. @mribbons fixes the issue in socketsupply/socket#420

from socket-examples.

Awesome! Thank you @mribbons!

from socket-examples.