Giter VIP home page Giter VIP logo

Comments (3)

tools-soda avatar tools-soda commented on June 15, 2024

SAS-2383

from soda-core.

alexandreio avatar alexandreio commented on June 15, 2024

Hi,

After investing and exploring the grammar rules, I have managed to modify them to accommodate the "abc=123" identifier. Here is the adjusted segment of the grammar:

`identifier:
IDENTIFIER_TABLE_NAME_UNQUOTED
| IDENTIFIER_DOUBLE_QUOTE
| IDENTIFIER_BACKTICK
| MIN
| MAX
| AVG;

IDENTIFIER_TABLE_NAME_UNQUOTED:
[a-zA-Z_$] ~(
' '
| '<'
| '>'
| '('
| ')'
| '['
| ']'
| ','
)*;
`

To achieve this, I introduced a new rule specifically tailored to include the '=' character. My decision to create a separate rule was influenced by a desire to maintain the integrity of the existing threshold_value rule and prevent any potential disruptions to its functionality.

I would appreciate any feedback or suggestions you might have regarding this modification. Is there anything else that I should take into consideration to ensure seamless integration and functionality?

from soda-core.

alexandreio avatar alexandreio commented on June 15, 2024

After some more tests the solution above not worked very well. I was able to fix this issue with Dremio updating the original IDENTIFIER_UNQUOTED to
IDENTIFIER_UNQUOTED: [a-zA-Z_=$] ~( ' ' | '<' | '>' | '(' | ')' | '[' | ']' | ',' )*;

And the logic to add "" in the abc=123 I've added in the dremio data source

from soda-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.