Comments (3)
SAS-2383
from soda-core.
Hi,
After investing and exploring the grammar rules, I have managed to modify them to accommodate the "abc=123" identifier. Here is the adjusted segment of the grammar:
`identifier:
IDENTIFIER_TABLE_NAME_UNQUOTED
| IDENTIFIER_DOUBLE_QUOTE
| IDENTIFIER_BACKTICK
| MIN
| MAX
| AVG;
IDENTIFIER_TABLE_NAME_UNQUOTED:
[a-zA-Z_$] ~(
' '
| '<'
| '>'
| '('
| ')'
| '['
| ']'
| ','
)*;
`
To achieve this, I introduced a new rule specifically tailored to include the '=' character. My decision to create a separate rule was influenced by a desire to maintain the integrity of the existing threshold_value rule and prevent any potential disruptions to its functionality.
I would appreciate any feedback or suggestions you might have regarding this modification. Is there anything else that I should take into consideration to ensure seamless integration and functionality?
from soda-core.
After some more tests the solution above not worked very well. I was able to fix this issue with Dremio updating the original IDENTIFIER_UNQUOTED to
IDENTIFIER_UNQUOTED: [a-zA-Z_=$] ~( ' ' | '<' | '>' | '(' | ')' | '[' | ']' | ',' )*;
And the logic to add "" in the abc=123 I've added in the dremio data source
from soda-core.
Related Issues (20)
- SodaCore 3.0.48 is not compatible with Airflow 2.7 HOT 2
- Duplicate count throw TypeError if column not exist HOT 2
- Parser does not support otherwise legal table valued functions HOT 1
- [test] Testing the updated integration HOT 1
- Profiler frequent_values Error When There's only one unique value in column: Source - Trino HOT 2
- Error connection with SQL and param string Trusted_Connection=True HOT 4
- Schema checks not working for DuckDB connection HOT 4
- Antlr doesn't parse composite threshold in freshness check HOT 2
- duplicate_count semantics are unclear and surprising HOT 1
- Regex pattern issue for (at least) SQL Server data source HOT 1
- "Between" threshold produces warning when using variables HOT 1
- Functions from PostGIS extensions can not be found HOT 1
- Slack soda-community access HOT 1
- Datahub intergration HOT 2
- Update Pydantic dependency HOT 1
- MySQL library installation Windows bluescreen HOT 5
- Support nested columns HOT 2
- samples limit is not honored by failed rows checks HOT 4
- Snowflake Regex Collate error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from soda-core.